The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [RFC PATCH v2 13/28] mm/damon/sysfs: implement filter dir files
Date: Tue, 12 May 2026 07:36:28 -0700	[thread overview]
Message-ID: <20260512143645.113201-14-sj@kernel.org> (raw)
In-Reply-To: <20260512143645.113201-1-sj@kernel.org>

Implement sysfs files under the data probe filter directory for letting
users to configure each filter.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 mm/damon/sysfs.c | 114 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 114 insertions(+)

diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index 25487a0268cbe..ed7bb734a236b 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -753,6 +753,9 @@ static const struct kobj_type damon_sysfs_intervals_ktype = {
 
 struct damon_sysfs_filter {
 	struct kobject kobj;
+	enum damon_filter_type type;
+	bool matching;
+	bool allow;
 };
 
 static struct damon_sysfs_filter *damon_sysfs_filter_alloc(void)
@@ -760,6 +763,105 @@ static struct damon_sysfs_filter *damon_sysfs_filter_alloc(void)
 	return kzalloc_obj(struct damon_sysfs_filter);
 }
 
+struct damon_sysfs_filter_type_name {
+	enum damon_filter_type type;
+	char *name;
+};
+
+static const struct damon_sysfs_filter_type_name
+damon_sysfs_filter_type_names[] = {
+	{
+		.type = DAMON_FILTER_TYPE_ANON,
+		.name = "anon",
+	},
+};
+
+static ssize_t type_show(struct kobject *kobj,
+		struct kobj_attribute *attr, char *buf)
+{
+	struct damon_sysfs_filter *filter = container_of(kobj,
+			struct damon_sysfs_filter, kobj);
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(damon_sysfs_filter_type_names); i++) {
+		const struct damon_sysfs_filter_type_name *type_name;
+
+		type_name = &damon_sysfs_filter_type_names[i];
+		if (type_name->type == filter->type)
+			return sysfs_emit(buf, "%s\n", type_name->name);
+	}
+	return -EINVAL;
+}
+
+static ssize_t type_store(struct kobject *kobj,
+		struct kobj_attribute *attr, const char *buf, size_t count)
+{
+	struct damon_sysfs_filter *filter = container_of(kobj,
+			struct damon_sysfs_filter, kobj);
+	ssize_t ret = -EINVAL;
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(damon_sysfs_filter_type_names); i++) {
+		const struct damon_sysfs_filter_type_name *type_name;
+
+		type_name = &damon_sysfs_filter_type_names[i];
+		if (sysfs_streq(buf, type_name->name)) {
+			filter->type = type_name->type;
+			ret = count;
+			break;
+		}
+	}
+	return ret;
+}
+
+static ssize_t matching_show(struct kobject *kobj,
+		struct kobj_attribute *attr, char *buf)
+{
+	struct damon_sysfs_filter *filter = container_of(kobj,
+			struct damon_sysfs_filter, kobj);
+
+	return sysfs_emit(buf, "%c\n", filter->matching ? 'Y' : 'N');
+}
+
+static ssize_t matching_store(struct kobject *kobj,
+		struct kobj_attribute *attr, const char *buf, size_t count)
+{
+	struct damon_sysfs_filter *filter = container_of(kobj,
+			struct damon_sysfs_filter, kobj);
+	bool matching;
+	int err = kstrtobool(buf, &matching);
+
+	if (err)
+		return err;
+
+	filter->matching = matching;
+	return count;
+}
+
+static ssize_t allow_show(struct kobject *kobj,
+		struct kobj_attribute *attr, char *buf)
+{
+	struct damon_sysfs_filter *filter = container_of(kobj,
+			struct damon_sysfs_filter, kobj);
+
+	return sysfs_emit(buf, "%c\n", filter->allow ? 'Y' : 'N');
+}
+
+static ssize_t allow_store(struct kobject *kobj,
+		struct kobj_attribute *attr, const char *buf, size_t count)
+{
+	struct damon_sysfs_filter *filter = container_of(kobj,
+			struct damon_sysfs_filter, kobj);
+	bool allow;
+	int err = kstrtobool(buf, &allow);
+
+	if (err)
+		return err;
+
+	filter->allow = allow;
+	return count;
+}
+
 static void damon_sysfs_filter_release(struct kobject *kobj)
 {
 	struct damon_sysfs_filter *filter = container_of(kobj,
@@ -768,7 +870,19 @@ static void damon_sysfs_filter_release(struct kobject *kobj)
 	kfree(filter);
 }
 
+static struct kobj_attribute damon_sysfs_filter_type_attr =
+		__ATTR_RW_MODE(type, 0600);
+
+static struct kobj_attribute damon_sysfs_filter_matching_attr =
+		__ATTR_RW_MODE(matching, 0600);
+
+static struct kobj_attribute damon_sysfs_filter_allow_attr =
+		__ATTR_RW_MODE(allow, 0600);
+
 static struct attribute *damon_sysfs_filter_attrs[] = {
+	&damon_sysfs_filter_type_attr.attr,
+	&damon_sysfs_filter_matching_attr.attr,
+	&damon_sysfs_filter_allow_attr.attr,
 	NULL,
 };
 ATTRIBUTE_GROUPS(damon_sysfs_filter);
-- 
2.47.3

  parent reply	other threads:[~2026-05-12 14:37 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 14:36 [RFC PATCH v2 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 01/28] mm/damon/core: introduce struct damon_probe SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 02/28] mm/damon/core: embed damon_probe objects in damon_ctx SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 03/28] mm/damon/core: introduce damon_filter SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 04/28] mm/damon/core: commit probes SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 05/28] mm/damon/core: introduce damon_region->probe_hits SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 06/28] mm/damon/core: introduce damon_ops->apply_probes SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 07/28] mm/damon/core: do data attributes monitoring SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 08/28] mm/damon/paddr: support " SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 09/28] mm/damon/sysfs: implement probes dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 10/28] mm/damon/sysfs: implement probe dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 11/28] mm/damon/sysfs: implement filters directory SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 12/28] mm/damon/sysfs: implement filter dir SeongJae Park
2026-05-12 14:36 ` SeongJae Park [this message]
2026-05-12 14:36 ` [RFC PATCH v2 14/28] mm/damon/sysfs: setup probes on DAMON core API parameters SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 15/28] mm/damon/sysfs-schemes: implement tried_regions/<r>/probes/ SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 16/28] mm/damon/sysfs-schemes: implement probe dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 17/28] mm/damon/sysfs-schemes: implement probe/hits file SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 18/28] mm/damon: trace probe_hits SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 19/28] selftests/damon/sysfs.sh: test probes dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 20/28] Docs/mm/damon/design: document data attributes monitoring SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 21/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 22/28] mm/damon/core: introduce DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 23/28] mm/damon/paddr: support DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 24/28] mm/damon/sysfs: add filters/<F>/path file SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 25/28] mm/damon/sysfs-schemes: move memcg_path_to_id() to sysfs-common SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 26/28] mm/damon/sysfs: setup damon_filter->memcg_id from path SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 27/28] Docs/mm/damon/design: update for memcg damon filter SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 28/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260512143645.113201-14-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox