From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH v2 15/28] mm/damon/sysfs-schemes: implement tried_regions/<r>/probes/
Date: Tue, 12 May 2026 07:36:30 -0700 [thread overview]
Message-ID: <20260512143645.113201-16-sj@kernel.org> (raw)
In-Reply-To: <20260512143645.113201-1-sj@kernel.org>
Implement a sysfs directory for showing the per-region probe hit counts.
It is named 'probes/' and located under the DAMOS tried region
directory.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/sysfs-schemes.c | 65 ++++++++++++++++++++++++++++++++++++++--
1 file changed, 62 insertions(+), 3 deletions(-)
diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
index 5d966ac864193..b2dcbdf1840e4 100644
--- a/mm/damon/sysfs-schemes.c
+++ b/mm/damon/sysfs-schemes.c
@@ -10,6 +10,32 @@
#include "sysfs-common.h"
+/*
+ * probes directory
+ */
+
+struct damos_sysfs_probes {
+ struct kobject kobj;
+};
+
+static struct damos_sysfs_probes *damos_sysfs_probes_alloc(void)
+{
+ return kzalloc_obj(struct damos_sysfs_probes);
+}
+
+static void damos_sysfs_probes_release(struct kobject *kobj)
+{
+ struct damos_sysfs_probes *probes = container_of(kobj,
+ struct damos_sysfs_probes, kobj);
+
+ kfree(probes);
+}
+
+static const struct kobj_type damos_sysfs_probes_ktype = {
+ .release = damos_sysfs_probes_release,
+ .sysfs_ops = &kobj_sysfs_ops,
+};
+
/*
* scheme region directory
*/
@@ -20,6 +46,7 @@ struct damon_sysfs_scheme_region {
unsigned int nr_accesses;
unsigned int age;
unsigned long sz_filter_passed;
+ struct damos_sysfs_probes *probes;
struct list_head list;
};
@@ -34,10 +61,36 @@ static struct damon_sysfs_scheme_region *damon_sysfs_scheme_region_alloc(
sysfs_region->ar = region->ar;
sysfs_region->nr_accesses = region->nr_accesses_bp / 10000;
sysfs_region->age = region->age;
+ sysfs_region->probes = NULL;
INIT_LIST_HEAD(&sysfs_region->list);
return sysfs_region;
}
+static int damos_sysfs_region_add_dirs(
+ struct damon_sysfs_scheme_region *region)
+{
+ struct damos_sysfs_probes *probes = damos_sysfs_probes_alloc();
+ int err;
+
+ if (!probes)
+ return -ENOMEM;
+ err = kobject_init_and_add(&probes->kobj, &damos_sysfs_probes_ktype,
+ ®ion->kobj, "probes");
+ if (err) {
+ kobject_put(&probes->kobj);
+ return err;
+ }
+
+ region->probes = probes;
+ return 0;
+}
+
+static void damos_sysfs_region_rm_dirs(
+ struct damon_sysfs_scheme_region *region)
+{
+ kobject_put(®ion->probes->kobj);
+}
+
static ssize_t start_show(struct kobject *kobj, struct kobj_attribute *attr,
char *buf)
{
@@ -165,6 +218,7 @@ static void damon_sysfs_scheme_regions_rm_dirs(
list_for_each_entry_safe(r, next, ®ions->regions_list, list) {
/* release function deletes it from the list */
+ damos_sysfs_region_rm_dirs(r);
kobject_put(&r->kobj);
regions->nr_regions--;
}
@@ -2998,9 +3052,14 @@ void damos_sysfs_populate_region_dir(struct damon_sysfs_schemes *sysfs_schemes,
if (kobject_init_and_add(®ion->kobj,
&damon_sysfs_scheme_region_ktype,
&sysfs_regions->kobj, "%d",
- sysfs_regions->nr_regions)) {
- kobject_put(®ion->kobj);
- }
+ sysfs_regions->nr_regions))
+ goto out;
+ if (damos_sysfs_region_add_dirs(region))
+ goto out;
+ return;
+
+out:
+ kobject_put(®ion->kobj);
}
int damon_sysfs_schemes_clear_regions(
--
2.47.3
next prev parent reply other threads:[~2026-05-12 14:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 14:36 [RFC PATCH v2 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 01/28] mm/damon/core: introduce struct damon_probe SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 02/28] mm/damon/core: embed damon_probe objects in damon_ctx SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 03/28] mm/damon/core: introduce damon_filter SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 04/28] mm/damon/core: commit probes SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 05/28] mm/damon/core: introduce damon_region->probe_hits SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 06/28] mm/damon/core: introduce damon_ops->apply_probes SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 07/28] mm/damon/core: do data attributes monitoring SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 08/28] mm/damon/paddr: support " SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 09/28] mm/damon/sysfs: implement probes dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 10/28] mm/damon/sysfs: implement probe dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 11/28] mm/damon/sysfs: implement filters directory SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 12/28] mm/damon/sysfs: implement filter dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 13/28] mm/damon/sysfs: implement filter dir files SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 14/28] mm/damon/sysfs: setup probes on DAMON core API parameters SeongJae Park
2026-05-12 14:36 ` SeongJae Park [this message]
2026-05-12 14:36 ` [RFC PATCH v2 16/28] mm/damon/sysfs-schemes: implement probe dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 17/28] mm/damon/sysfs-schemes: implement probe/hits file SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 18/28] mm/damon: trace probe_hits SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 19/28] selftests/damon/sysfs.sh: test probes dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 20/28] Docs/mm/damon/design: document data attributes monitoring SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 21/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 22/28] mm/damon/core: introduce DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 23/28] mm/damon/paddr: support DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 24/28] mm/damon/sysfs: add filters/<F>/path file SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 25/28] mm/damon/sysfs-schemes: move memcg_path_to_id() to sysfs-common SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 26/28] mm/damon/sysfs: setup damon_filter->memcg_id from path SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 27/28] Docs/mm/damon/design: update for memcg damon filter SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 28/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512143645.113201-16-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox