The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [RFC PATCH v2 04/28] mm/damon/core: commit probes
Date: Tue, 12 May 2026 07:36:19 -0700	[thread overview]
Message-ID: <20260512143645.113201-5-sj@kernel.org> (raw)
In-Reply-To: <20260512143645.113201-1-sj@kernel.org>

Update damon_commit_ctx() to commit installed data probes, too.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 mm/damon/core.c | 104 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 104 insertions(+)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index d01417955a3b4..240cae1420c12 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -133,11 +133,34 @@ void damon_add_filter(struct damon_probe *p, struct damon_filter *f)
 	list_add_tail(&f->list, &p->filters);
 }
 
+static void damon_del_filter(struct damon_filter *f)
+{
+	list_del(&f->list);
+}
+
 static void damon_free_filter(struct damon_filter *f)
 {
 	kfree(f);
 }
 
+static void damon_destroy_filter(struct damon_filter *f)
+{
+	damon_del_filter(f);
+	damon_free_filter(f);
+}
+
+static struct damon_filter *damon_nth_filter(int n, struct damon_probe *p)
+{
+	struct damon_filter *f;
+	int i = 0;
+
+	damon_for_each_filter(f, p) {
+		if (i++ == n)
+			return f;
+	}
+	return NULL;
+}
+
 struct damon_probe *damon_new_probe(void)
 {
 	struct damon_probe *p;
@@ -175,6 +198,18 @@ static void damon_destroy_probe(struct damon_probe *p)
 	damon_free_probe(p);
 }
 
+static struct damon_probe *damon_nth_probe(int n, struct damon_ctx *ctx)
+{
+	struct damon_probe *p;
+	int i = 0;
+
+	damon_for_each_probe(p, ctx) {
+		if (i++ == n)
+			return p;
+	}
+	return NULL;
+}
+
 #ifdef CONFIG_DAMON_DEBUG_SANITY
 static void damon_verify_new_region(unsigned long start, unsigned long end)
 {
@@ -1386,6 +1421,72 @@ static int damon_commit_targets(
 	return 0;
 }
 
+static void damon_commit_filter(struct damon_filter *dst,
+		struct damon_filter *src)
+{
+	dst->type = src->type;
+	dst->matching = src->matching;
+	dst->allow = src->allow;
+}
+
+static int damon_commit_filters(struct damon_probe *dst,
+		struct damon_probe *src)
+{
+	struct damon_filter *dst_filter, *next, *src_filter, *new_filter;
+	int i = 0, j = 0;
+
+	damon_for_each_filter_safe(dst_filter, next, dst) {
+		src_filter = damon_nth_filter(i++, src);
+		if (src_filter)
+			damon_commit_filter(dst_filter, src_filter);
+		else
+			damon_destroy_filter(dst_filter);
+	}
+
+	damon_for_each_filter_safe(src_filter, next, src) {
+		if (j++ < i)
+			continue;
+
+		new_filter = damon_new_filter(src_filter->type,
+				src_filter->matching, src_filter->allow);
+		if (!new_filter)
+			return -ENOMEM;
+		damon_add_filter(dst, new_filter);
+	}
+	return 0;
+}
+
+static int damon_commit_probes(struct damon_ctx *dst, struct damon_ctx *src)
+{
+	struct damon_probe *dst_probe, *next, *src_probe, *new_probe;
+	int i = 0, j = 0, err;
+
+	damon_for_each_probe_safe(dst_probe, next, dst) {
+		src_probe = damon_nth_probe(i++, src);
+		if (src_probe) {
+			err = damon_commit_filters(dst_probe, src_probe);
+			if (err)
+				return err;
+		} else {
+			damon_destroy_probe(dst_probe);
+		}
+	}
+
+	damon_for_each_probe_safe(src_probe, next, src) {
+		if (j++ < i)
+			continue;
+
+		new_probe = damon_new_probe();
+		if (!new_probe)
+			return -ENOMEM;
+		damon_add_probe(dst, new_probe);
+		err = damon_commit_filters(new_probe, src_probe);
+		if (err)
+			return err;
+	}
+	return 0;
+}
+
 /**
  * damon_commit_ctx() - Commit parameters of a DAMON context to another.
  * @dst:	The commit destination DAMON context.
@@ -1442,6 +1543,9 @@ int damon_commit_ctx(struct damon_ctx *dst, struct damon_ctx *src)
 	}
 	dst->pause = src->pause;
 	dst->ops = src->ops;
+	err = damon_commit_probes(dst, src);
+	if (err)
+		return err;
 	dst->addr_unit = src->addr_unit;
 	dst->min_region_sz = src->min_region_sz;
 
-- 
2.47.3

  parent reply	other threads:[~2026-05-12 14:36 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 14:36 [RFC PATCH v2 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 01/28] mm/damon/core: introduce struct damon_probe SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 02/28] mm/damon/core: embed damon_probe objects in damon_ctx SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 03/28] mm/damon/core: introduce damon_filter SeongJae Park
2026-05-12 14:36 ` SeongJae Park [this message]
2026-05-12 14:36 ` [RFC PATCH v2 05/28] mm/damon/core: introduce damon_region->probe_hits SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 06/28] mm/damon/core: introduce damon_ops->apply_probes SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 07/28] mm/damon/core: do data attributes monitoring SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 08/28] mm/damon/paddr: support " SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 09/28] mm/damon/sysfs: implement probes dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 10/28] mm/damon/sysfs: implement probe dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 11/28] mm/damon/sysfs: implement filters directory SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 12/28] mm/damon/sysfs: implement filter dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 13/28] mm/damon/sysfs: implement filter dir files SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 14/28] mm/damon/sysfs: setup probes on DAMON core API parameters SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 15/28] mm/damon/sysfs-schemes: implement tried_regions/<r>/probes/ SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 16/28] mm/damon/sysfs-schemes: implement probe dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 17/28] mm/damon/sysfs-schemes: implement probe/hits file SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 18/28] mm/damon: trace probe_hits SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 19/28] selftests/damon/sysfs.sh: test probes dir SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 20/28] Docs/mm/damon/design: document data attributes monitoring SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 21/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 22/28] mm/damon/core: introduce DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 23/28] mm/damon/paddr: support DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 24/28] mm/damon/sysfs: add filters/<F>/path file SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 25/28] mm/damon/sysfs-schemes: move memcg_path_to_id() to sysfs-common SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 26/28] mm/damon/sysfs: setup damon_filter->memcg_id from path SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 27/28] Docs/mm/damon/design: update for memcg damon filter SeongJae Park
2026-05-12 14:36 ` [RFC PATCH v2 28/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260512143645.113201-5-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox