The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH v2] genirq: Add the entropy pool function to the PPI interrupt handler
@ 2026-06-16  8:17 Enlin Mu
  2026-06-16  9:38 ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Enlin Mu @ 2026-06-16  8:17 UTC (permalink / raw)
  To: tglx, linux-kernel, enlin.mu, enlin.mu; +Cc: linux-hardening

Accelerate the entropy pool initialization process.
The function handle_irq_event_percpu adds entropy pool
initialization, but this logic is missing in the PPI interrupt handler.
I think this was simply an accidental omission.

Signed-off-by: Enlin Mu <enlin.mu@linux.dev>
---
 kernel/irq/chip.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index de754db414d1..cbbd7e7d1156 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -926,6 +926,7 @@ void handle_percpu_devid_irq(struct irq_desc *desc)
 		trace_irq_handler_entry(irq, action);
 		res = action->handler(irq, raw_cpu_ptr(action->percpu_dev_id));
 		trace_irq_handler_exit(irq, action, res);
+		add_interrupt_randomness(irq);
 	} else {
 		bool enabled = cpumask_test_cpu(cpu, desc->percpu_enabled);
 
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] genirq: Add the entropy pool function to the PPI interrupt handler
  2026-06-16  8:17 Enlin Mu
@ 2026-06-16  9:38 ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2026-06-16  9:38 UTC (permalink / raw)
  To: Enlin Mu; +Cc: tglx, linux-kernel, enlin.mu, linux-hardening

On Tue, Jun 16, 2026 at 04:17:30PM +0800, Enlin Mu wrote:
> Accelerate the entropy pool initialization process.
> The function handle_irq_event_percpu adds entropy pool
> initialization, but this logic is missing in the PPI interrupt handler.
> I think this was simply an accidental omission.
> 
> Signed-off-by: Enlin Mu <enlin.mu@linux.dev>
> ---
>  kernel/irq/chip.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index de754db414d1..cbbd7e7d1156 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -926,6 +926,7 @@ void handle_percpu_devid_irq(struct irq_desc *desc)
>  		trace_irq_handler_entry(irq, action);
>  		res = action->handler(irq, raw_cpu_ptr(action->percpu_dev_id));
>  		trace_irq_handler_exit(irq, action, res);
> +		add_interrupt_randomness(irq);
>  	} else {
>  		bool enabled = cpumask_test_cpu(cpu, desc->percpu_enabled);
>  
> -- 
> 2.39.5
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] genirq: Add the entropy pool function to the PPI interrupt handler
@ 2026-06-16 10:02 Enlin Mu
  2026-06-16 14:27 ` Michael Kelley
  0 siblings, 1 reply; 4+ messages in thread
From: Enlin Mu @ 2026-06-16 10:02 UTC (permalink / raw)
  To: tglx, linux-kernel, enlin.mu, enlin.mu; +Cc: linux-hardening

Accelerate the entropy pool initialization process.
The function handle_irq_event_percpu adds entropy pool
initialization, but this logic is missing in the PPI interrupt handler.
I think this was simply an accidental omission.

Signed-off-by: Enlin Mu <enlin.mu@linux.dev>
---
v2:updated the commit message
---
 kernel/irq/chip.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index de754db414d1..cbbd7e7d1156 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -926,6 +926,7 @@ void handle_percpu_devid_irq(struct irq_desc *desc)
 		trace_irq_handler_entry(irq, action);
 		res = action->handler(irq, raw_cpu_ptr(action->percpu_dev_id));
 		trace_irq_handler_exit(irq, action, res);
+		add_interrupt_randomness(irq);
 	} else {
 		bool enabled = cpumask_test_cpu(cpu, desc->percpu_enabled);
 
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH v2] genirq: Add the entropy pool function to the PPI interrupt handler
  2026-06-16 10:02 [PATCH v2] genirq: Add the entropy pool function to the PPI interrupt handler Enlin Mu
@ 2026-06-16 14:27 ` Michael Kelley
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Kelley @ 2026-06-16 14:27 UTC (permalink / raw)
  To: Enlin Mu, tglx@kernel.org, linux-kernel@vger.kernel.org,
	enlin.mu@unisoc.com
  Cc: linux-hardening@vger.kernel.org

From: Enlin Mu <enlin.mu@linux.dev> Sent: Tuesday, June 16, 2026 3:02 AM
> 
> Accelerate the entropy pool initialization process.
> The function handle_irq_event_percpu adds entropy pool
> initialization, but this logic is missing in the PPI interrupt handler.
> I think this was simply an accidental omission.

This change has already been made via a patch I submitted. The
change is in the 7.1 release. See commit fd7400cfcbaa and a
follow-on fix in commit 512718bbc51b.

Michael

> 
> Signed-off-by: Enlin Mu <enlin.mu@linux.dev>
> ---
> v2:updated the commit message
> ---
>  kernel/irq/chip.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index de754db414d1..cbbd7e7d1156 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -926,6 +926,7 @@ void handle_percpu_devid_irq(struct irq_desc *desc)
>  		trace_irq_handler_entry(irq, action);
>  		res = action->handler(irq, raw_cpu_ptr(action->percpu_dev_id));
>  		trace_irq_handler_exit(irq, action, res);
> +		add_interrupt_randomness(irq);
>  	} else {
>  		bool enabled = cpumask_test_cpu(cpu, desc->percpu_enabled);
> 
> --
> 2.39.5
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-06-16 14:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-16 10:02 [PATCH v2] genirq: Add the entropy pool function to the PPI interrupt handler Enlin Mu
2026-06-16 14:27 ` Michael Kelley
  -- strict thread matches above, loose matches on Subject: below --
2026-06-16  8:17 Enlin Mu
2026-06-16  9:38 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox