[PATCH] iio: light: al3010: fix incorrect scale for the highest gain range

[PATCH] iio: light: al3010: fix incorrect scale for the highest gain range

[Vidhu Sarwal]

al3010_scales[] encodes the highest gain range as {0, 1187200}.
For IIO_VAL_INT_PLUS_MICRO, the fractional part must be less than
1000000, so the scale 1.1872 should instead be represented as
{1, 187200}.

Since write_raw() compares the value from userspace against this
table, writing  1.1872 scale never matches the malformed
entry and returns -EINVAL. As a result, the highest gain range cannot
be selected. Reading the scale in that state also reports the malformed
value.   

Fixes: c36b5195ab70 ("iio: light: add Dyna-Image AL3010 driver")
Signed-off-by: Vidhu Sarwal <vidhu.linux@gmail.com>
---
 drivers/iio/light/al3010.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c
index d603b4a6b8e8..cc39f8af4ea3 100644
--- a/drivers/iio/light/al3010.c
+++ b/drivers/iio/light/al3010.c
@@ -42,7 +42,7 @@ enum al3xxxx_range {
 };
 
 static const int al3010_scales[][2] = {
-	{0, 1187200}, {0, 296800}, {0, 74200}, {0, 18600}
+	{1, 187200}, {0, 296800}, {0, 74200}, {0, 18600}
 };
 
 static const struct regmap_config al3010_regmap_config = {
-- 
2.53.0

Re: [PATCH] iio: light: al3010: fix incorrect scale for the highest gain range

[Andy Shevchenko]

On Thu, Jul 02, 2026 at 10:59:13AM +0530, Vidhu Sarwal wrote:
> al3010_scales[] encodes the highest gain range as {0, 1187200}.
> For IIO_VAL_INT_PLUS_MICRO, the fractional part must be less than
> 1000000, so the scale 1.1872 should instead be represented as
> {1, 187200}.
> 
> Since write_raw() compares the value from userspace against this
> table, writing  1.1872 scale never matches the malformed
> entry and returns -EINVAL. As a result, the highest gain range cannot
> be selected. Reading the scale in that state also reports the malformed
> value.   

Trailing spaces in the last line of the above paragraph.

> 
> Fixes: c36b5195ab70 ("iio: light: add Dyna-Image AL3010 driver")
> Signed-off-by: Vidhu Sarwal <vidhu.linux@gmail.com>

...

>  static const int al3010_scales[][2] = {
> -	{0, 1187200}, {0, 296800}, {0, 74200}, {0, 18600}
> +	{1, 187200}, {0, 296800}, {0, 74200}, {0, 18600}

While at it, add a trailing comma.

>  };

Otherwise LGTM, thanks.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: light: al3010: fix incorrect scale for the highest gain range

[Jonathan Cameron]

On Thu, 2 Jul 2026 12:44:54 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Thu, Jul 02, 2026 at 10:59:13AM +0530, Vidhu Sarwal wrote:
> > al3010_scales[] encodes the highest gain range as {0, 1187200}.
> > For IIO_VAL_INT_PLUS_MICRO, the fractional part must be less than
> > 1000000, so the scale 1.1872 should instead be represented as
> > {1, 187200}.
> > 
> > Since write_raw() compares the value from userspace against this
> > table, writing  1.1872 scale never matches the malformed
> > entry and returns -EINVAL. As a result, the highest gain range cannot
> > be selected. Reading the scale in that state also reports the malformed
> > value.     
> 
> Trailing spaces in the last line of the above paragraph.
> 
> > 
> > Fixes: c36b5195ab70 ("iio: light: add Dyna-Image AL3010 driver")
> > Signed-off-by: Vidhu Sarwal <vidhu.linux@gmail.com>  
> 
> ...
> 
> >  static const int al3010_scales[][2] = {
> > -	{0, 1187200}, {0, 296800}, {0, 74200}, {0, 18600}
> > +	{1, 187200}, {0, 296800}, {0, 74200}, {0, 18600}  
> 
> While at it, add a trailing comma.
Can we take opportunity to move to IIO (well my) preferred formatting
	{ 1, 187200 }, { 0, 296800 }, { 0, 74200 }, { 0, 18600 },  

Thanks,

Jonathan

> 
> >  };  
> 
> Otherwise LGTM, thanks.
> 

[PATCH v2] iio: light: al3010: fix incorrect scale for the highest gain range

[Vidhu Sarwal]

al3010_scales[] encodes the highest gain range as {0, 1187200}.
For IIO_VAL_INT_PLUS_MICRO, the fractional part must be less than
1000000, so the scale 1.1872 should instead be represented as
{ 1, 187200 }.

Since write_raw() compares the value from userspace against this
table, writing the advertised 1.1872 scale never matches the malformed
entry and returns -EINVAL. As a result, the highest gain range cannot
be selected. Reading the scale in that state also reports the malformed
value.

Fixes: c36b5195ab70 ("iio: light: add Dyna-Image AL3010 driver")
Signed-off-by: Vidhu Sarwal <vidhu.linux@gmail.com>
---
v2:
- Remove trailing whitespace in commit message and Add trailing comma after last array element (Andy)
- Use IIO preferred brace spacing (Jonathan)

 drivers/iio/light/al3010.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c
index d603b4a6b8e8..ca1d7fd6defb 100644
--- a/drivers/iio/light/al3010.c
+++ b/drivers/iio/light/al3010.c
@@ -42,7 +42,7 @@ enum al3xxxx_range {
 };
 
 static const int al3010_scales[][2] = {
-	{0, 1187200}, {0, 296800}, {0, 74200}, {0, 18600}
+	{ 1, 187200 }, { 0, 296800 }, { 0, 74200 }, { 0, 18600 },
 };
 
 static const struct regmap_config al3010_regmap_config = {
-- 
2.53.0

Re: [PATCH v2] iio: light: al3010: fix incorrect scale for the highest gain range

[Andy Shevchenko]

On Sat, Jul 04, 2026 at 05:22:45PM +0530, Vidhu Sarwal wrote:
> al3010_scales[] encodes the highest gain range as {0, 1187200}.
> For IIO_VAL_INT_PLUS_MICRO, the fractional part must be less than
> 1000000, so the scale 1.1872 should instead be represented as
> { 1, 187200 }.
> 
> Since write_raw() compares the value from userspace against this
> table, writing the advertised 1.1872 scale never matches the malformed
> entry and returns -EINVAL. As a result, the highest gain range cannot
> be selected. Reading the scale in that state also reports the malformed
> value.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] iio: light: al3010: fix incorrect scale for the highest gain range

[Jonathan Cameron]

On Sat, 4 Jul 2026 15:13:42 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Sat, Jul 04, 2026 at 05:22:45PM +0530, Vidhu Sarwal wrote:
> > al3010_scales[] encodes the highest gain range as {0, 1187200}.
> > For IIO_VAL_INT_PLUS_MICRO, the fractional part must be less than
> > 1000000, so the scale 1.1872 should instead be represented as
> > { 1, 187200 }.
> > 
> > Since write_raw() compares the value from userspace against this
> > table, writing the advertised 1.1872 scale never matches the malformed
> > entry and returns -EINVAL. As a result, the highest gain range cannot
> > be selected. Reading the scale in that state also reports the malformed
> > value.  
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 

For future reference, please never send a new version in reply to an earlier
version. It both gets very confusing as threads develop and also puts your
patches way back in the maintainers inbox, which often slows down getting them
applied.

Applied and marked for stable 

thanks, Jonathan