[PATCH] usb: typec: class: drop PD lookup reference

[PATCH] usb: typec: class: drop PD lookup reference

[Shuangpeng Bai]

usb_power_delivery_find() wraps class_find_device_by_name(). That helper
returns a device reference that must be released by the caller.

select_usb_power_delivery_store() only needs this reference while calling
the pd_set callback. Drop it once the callback returns. Otherwise the sysfs
write can pin the selected USB Power Delivery object and prevent it from
being released on unregister.

Fixes: a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners")
Signed-off-by: Shuangpeng Bai <shuangpeng.kernel@gmail.com>
---
 drivers/usb/typec/class.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index 0977581ad1b6..0595e8cb83aa 100644
--- a/drivers/usb/typec/class.c
+++ b/drivers/usb/typec/class.c
@@ -1619,6 +1619,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
 		return -EINVAL;
 
 	ret = port->ops->pd_set(port, pd);
+	put_device(&pd->dev);
 	if (ret)
 		return ret;
 
-- 
2.43.0

Re: [PATCH] usb: typec: class: drop PD lookup reference

[Heikki Krogerus]

On Thu, Jul 02, 2026 at 03:13:29PM -0400, Shuangpeng Bai wrote:
> usb_power_delivery_find() wraps class_find_device_by_name(). That helper
> returns a device reference that must be released by the caller.
> 
> select_usb_power_delivery_store() only needs this reference while calling
> the pd_set callback. Drop it once the callback returns. Otherwise the sysfs
> write can pin the selected USB Power Delivery object and prevent it from
> being released on unregister.
> 
> Fixes: a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners")
> Signed-off-by: Shuangpeng Bai <shuangpeng.kernel@gmail.com>

You need to Cc stable@vger.kernel.org

https://docs.kernel.org/process/5.Posting.html#sending-the-patch

thanks,

> ---
>  drivers/usb/typec/class.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index 0977581ad1b6..0595e8cb83aa 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1619,6 +1619,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
>  		return -EINVAL;
>  
>  	ret = port->ops->pd_set(port, pd);
> +	put_device(&pd->dev);
>  	if (ret)
>  		return ret;
>  
> -- 
> 2.43.0

-- 
heikki