The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	hch@lst.de, elver@google.com, kbusch@kernel.org,
	sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org,
	gjoyce@linux.ibm.com
Subject: Re: [PATCH v3 07/18] nvme: add context annotations for nvme_subsystem::lock
Date: Thu, 9 Jul 2026 08:28:45 +0200	[thread overview]
Message-ID: <20260709062845.GA18056@lst.de> (raw)
In-Reply-To: <20260706141452.3008233-8-nilay@linux.ibm.com>

On Mon, Jul 06, 2026 at 07:44:09PM +0530, Nilay Shroff wrote:
> Wrap the initialization of nvme_subsystem::nsheads with
> context_unsafe(...) to suppress the context analysis warning emitted
> for INIT_LIST_HEAD() during object initialization.

Still not a fan of that vs adding a proper helper.

> nvme_ns_head is allocated with kzalloc(), so explicitly initializing
> nvme_ns_head::delayed_removal_secs to 0 in nvme_mpath_alloc_disk() is
> redundant. Remove the redundant initialization, which also avoids a
> false positive from Clang's context analysis.

Please split that into a prep patch.


  reply	other threads:[~2026-07-09  6:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 14:14 [PATCH v3 00/18] Support Clang context analysis for NVMe host drivers Nilay Shroff
2026-07-06 14:14 ` [PATCH v3 01/18] nvme: update nvme_passthru_end() signature Nilay Shroff
2026-07-06 14:14 ` [PATCH v3 02/18] nvme: add context annotations for nvme_passthru_{start|stop} Nilay Shroff
2026-07-06 14:14 ` [PATCH v3 03/18] nvme: add context annotations for nvme_ns_head::srcu Nilay Shroff
2026-07-06 14:14 ` [PATCH v3 04/18] nvme: add context annotations for nvme_ns_head::requeue_list Nilay Shroff
2026-07-06 14:14 ` [PATCH v3 05/18] nvme: add context annotations for nvme_ns_head::current_path Nilay Shroff
2026-07-06 16:08   ` Paul E. McKenney
2026-07-06 14:14 ` [PATCH v3 06/18] nvme: add context annotations for nvme_dev::shutdown_lock Nilay Shroff
2026-07-06 14:14 ` [PATCH v3 07/18] nvme: add context annotations for nvme_subsystem::lock Nilay Shroff
2026-07-09  6:28   ` Christoph Hellwig [this message]
2026-07-06 14:14 ` [PATCH v3 08/18] nvme: add context annotations for nvme_ctrl::ana_lock Nilay Shroff
2026-07-06 14:14 ` [PATCH v3 09/18] list: introduce LIST_HEAD_GUARDED Nilay Shroff
2026-07-09  6:29   ` Christoph Hellwig
2026-07-06 14:14 ` [PATCH v3 10/18] nvme: add context annotations for nvme_subsystems_lock Nilay Shroff
2026-07-09  6:31   ` Christoph Hellwig
2026-07-06 14:14 ` [PATCH v3 11/18] nvme: add context annotations in fabric.c Nilay Shroff
2026-07-09  6:31   ` Christoph Hellwig
2026-07-06 14:14 ` [PATCH v3 12/18] nvme: add context annotations for nvme_queue::sq_lock Nilay Shroff
2026-07-09  6:32   ` Christoph Hellwig
2026-07-06 14:14 ` [PATCH v3 13/18] nvme: add context annotations in rdma.c Nilay Shroff
2026-07-06 14:14 ` [PATCH v3 14/18] list: Permit context-unguarded access with list_empty_careful() Nilay Shroff
2026-07-09  6:30   ` Christoph Hellwig
2026-07-06 14:14 ` [PATCH v3 15/18] nvme: fix context analysis warning in rdma.c Nilay Shroff
2026-07-06 14:14 ` [PATCH v3 16/18] nvme: add context annotations in tcp.c Nilay Shroff
2026-07-06 14:14 ` [PATCH v3 17/18] nvme: fix context analysis warning " Nilay Shroff
2026-07-06 14:14 ` [PATCH v3 18/18] nvme: enable context analysis support for nvme host driver Nilay Shroff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260709062845.GA18056@lst.de \
    --to=hch@lst.de \
    --cc=axboe@fb.com \
    --cc=bvanassche@acm.org \
    --cc=elver@google.com \
    --cc=gjoyce@linux.ibm.com \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nilay@linux.ibm.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox