Re: [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sun, Jul 12, 2026 at 10:19:20PM +0800, Dylan Liu wrote:
> staging: iio: adt7316: Fix CamelCase naming for sysfs attributes
> 
> Fix multiple checkpatch.pl warnings complaining about CamelCase
> variable and function names.
> 
> In order to comply with standard Linux coding style and IIO ABI
> conventions, convert all uppercase abbreviations (AIN, DAC, Vref)
> in the adt7316 driver to lowercase snake_case.
> 
> Note that this patch changes the sysfs ABI for this driver, as
> the device attributes exposed to userspace are now lowercase
> (e.g., from 'AIN_internal_Vref' to 'ain_internal_vref'). This is
> necessary to bring the staging driver in line with the official
> IIO ABI.
> 
> Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
> ---
>  drivers/staging/iio/addac/adt7316.c | 228 ++++++++++++++--------------
>  1 file changed, 114 insertions(+), 114 deletions(-)
> 
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 59fb3bd26bc1..845d79591128 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -663,7 +663,7 @@ static IIO_DEVICE_ATTR(da_high_resolution, 0644,
>  		adt7316_store_da_high_resolution,
>  		0);
>  
> -static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,
> +static ssize_t adt7316_show_ain_internal_vref(struct device *dev,
>  					      struct device_attribute *attr,
>  					      char *buf)
>  {
> @@ -677,7 +677,7 @@ static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,
>  		!!(chip->config3 & ADT7516_AIN_IN_VREF));
>  }
>  
> -static ssize_t adt7316_store_AIN_internal_Vref(struct device *dev,
> +static ssize_t adt7316_store_ain_internal_vref(struct device *dev,
>  					       struct device_attribute *attr,
>  					       const char *buf,
>  					       size_t len)
> @@ -704,12 +704,12 @@ static ssize_t adt7316_store_AIN_internal_Vref(struct device *dev,
>  	return len;
>  }
>  
> -static IIO_DEVICE_ATTR(AIN_internal_Vref, 0644,
> -		adt7316_show_AIN_internal_Vref,
> -		adt7316_store_AIN_internal_Vref,
> +static IIO_DEVICE_ATTR(ain_internal_vref, 0644,
> +		adt7316_show_ain_internal_vref,
> +		adt7316_store_ain_internal_vref,
>  		0);

You just changed the user/kernel api, right?  Are you sure this is ok to
do?

thanks,

greg k-h