The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Dylan Liu <pxyforeverlove1314@gmail.com>
Cc: "Dylan Liu" <dylanliu050903@protonmail.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux@analog.com, linux-iio@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
Date: Mon, 13 Jul 2026 10:42:39 +0300	[thread overview]
Message-ID: <alSW7wR4XTKJqUU8@stanley.mountain> (raw)
In-Reply-To: <20260712141928.559844-1-dylanliu050903@protonmail.com>

On Sun, Jul 12, 2026 at 10:19:20PM +0800, Dylan Liu wrote:
> staging: iio: adt7316: Fix CamelCase naming for sysfs attributes
> 
> Fix multiple checkpatch.pl warnings complaining about CamelCase
> variable and function names.
> 
> In order to comply with standard Linux coding style and IIO ABI
> conventions, convert all uppercase abbreviations (AIN, DAC, Vref)
> in the adt7316 driver to lowercase snake_case.
> 
> Note that this patch changes the sysfs ABI for this driver, as
> the device attributes exposed to userspace are now lowercase
> (e.g., from 'AIN_internal_Vref' to 'ain_internal_vref'). This is
> necessary to bring the staging driver in line with the official
> IIO ABI.
> 
> Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
> ---
>  drivers/staging/iio/addac/adt7316.c | 228 ++++++++++++++--------------
>  1 file changed, 114 insertions(+), 114 deletions(-)
> 
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 59fb3bd26bc1..845d79591128 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -663,7 +663,7 @@ static IIO_DEVICE_ATTR(da_high_resolution, 0644,
>  		adt7316_store_da_high_resolution,
>  		0);
>  
> -static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,
> +static ssize_t adt7316_show_ain_internal_vref(struct device *dev,
>  					      struct device_attribute *attr,
>  					      char *buf)
>  {

These are scientific notation.  It's like making someone's
name lowercase to satisfy checkpatch.  The one rule is more important
than the other rule.

regards,
dan carpenter


      parent reply	other threads:[~2026-07-13  7:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-12 14:19 [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com> Dylan Liu
2026-07-12 14:25 ` Greg Kroah-Hartman
2026-07-12 14:25 ` Greg Kroah-Hartman
2026-07-12 14:56   ` 回复: " dylanliu050903
2026-07-12 15:05     ` Andy Shevchenko
2026-07-12 15:41       ` 回复: " dylanliu050903
2026-07-12 16:46         ` Joshua Crofts
2026-07-13  0:59           ` Jonathan Cameron
2026-07-13  7:42 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alSW7wR4XTKJqUU8@stanley.mountain \
    --to=error27@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=dylanliu050903@protonmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=pxyforeverlove1314@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox