Re: 回复： Re: 回复： Re: [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 12 Jul 2026 18:46:02 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> On Sun, 12 Jul 2026 15:41:54 +0000
> dylanliu050903 <dylanliu050903@protonmail.com> wrote:
> > Hi Andy,
> > 
> > First, I apologize for the HTML email earlier. I have fixed my email client settings.I was using the ProtonMail web client instead of `git send-email`, which unexpectedly defaulted to HTML.
> > 
> > Regarding the ABI change: I made a classic beginner mistake. I changed it purely because the `checkpatch.pl` script threw a warning suggesting it should be in snake_case. I blindly followed the script's advice without realizing that I was modifying a user/kernel ABI. 
> > 
> > I now understand that ABI stability (and aligning with IIO maintainers for any necessary staging transitions) absolutely takes precedence over resolving style warnings.
> > 
> > Please drop this patch. I will be much more careful with checkpatch warnings involving exposed interfaces in the future.I will also dive deeper into the codebase to ensure my future commits provide real value.
> > 
> > Thank you for your time and the guidance!
> > 
> > Best regards,
> > Dylan Liu
> >   
>

> Hi Dylan,
> 
> Please wrap your email body to 72 characters per line, as you would
> with a commit message. It's easier to read.
> 
> Thanks!

For any of the drivers in staging it is worth taking a look at lore.kernel.org
and seeing what has been proposed in the past. IIRC, this one has been the subject
of more than one attempt to clean it up. The userspace ABI is a long way with
compliant with IIO ABI. The challenge with sorting that out is that the changes
are invasive so you'd need to figure out how to test them.

Jonathan