The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: David Laight <david.laight.linux@gmail.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: "Chang S. Bae" <chang.seok.bae@intel.com>,
	Sohil Mehta <sohil.mehta@intel.com>,
	"Maciej W. Rozycki" <macro@orcam.me.uk>,
	linux-kernel@vger.kernel.org, x86@kernel.org, tglx@kernel.org,
	Ingo Molnar <mingo@redhat.com>,
	bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com
Subject: Re: [PATCH] x86/microcode/intel: Panic on partial microcode update
Date: Tue, 28 Jul 2026 23:09:23 +0100	[thread overview]
Message-ID: <20260728230923.2df52561@pumpkin> (raw)
In-Reply-To: <5eb49b65-7f33-4e5d-b800-b30a90b0516e@intel.com>

On Tue, 28 Jul 2026 13:48:20 -0700
Dave Hansen <dave.hansen@intel.com> wrote:

> On 7/28/26 11:56, David Laight wrote:
> >> WARN(), please. Not panic().
> >>  
> > PANIC_ON_WARN ....  
> 
> Right. That's kinda my point.
> 
> If you are of the tin-foil-hat-wearing persuasion, you are paranoid and
> can't get enough panic()s in your life. You have panic_on_warn=1 to
> magically transform all warnings into panic()s and warm your heart.
> 
> There's no warn_on_panic=1. The trusting don't have an analog.

And the panics are much harder to debug.
It isn't as though the code waits long enough after generating all the
'console' output to let syslogd get it to filestore.
We we trying to find why a customer system kept rebooting.
Eventually realised PANIC_ON_OOPS was set, turned it off and the silly bug
was obvious.

	David

  parent reply	other threads:[~2026-07-28 22:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 19:13 [PATCH] x86/microcode/intel: Panic on partial microcode update Chang S. Bae
2026-06-30 21:38 ` Dave Hansen
2026-06-30 21:47   ` Dave Hansen
2026-06-30 23:21     ` Borislav Petkov
2026-07-01 19:02     ` Chang S. Bae
2026-07-18 22:54     ` Maciej W. Rozycki
2026-07-19 15:52       ` Dave Hansen
2026-07-23 22:42         ` Maciej W. Rozycki
2026-07-27 12:35           ` Nikolay Borisov
2026-07-28 21:53             ` Maciej W. Rozycki
2026-07-27 20:36         ` Chang S. Bae
2026-07-27 21:59           ` Sohil Mehta
2026-07-28  2:58             ` Chang S. Bae
2026-07-28 14:12               ` Dave Hansen
2026-07-28 18:56                 ` David Laight
2026-07-28 20:48                   ` Dave Hansen
2026-07-28 21:47                     ` Maciej W. Rozycki
2026-07-28 21:53                       ` Dave Hansen
2026-07-28 22:09                     ` David Laight [this message]
2026-07-08 21:18 ` [PATCH v2] x86/microcode/intel: Taint kernel on partial update Chang S. Bae
2026-07-27 11:27   ` Nikolay Borisov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260728230923.2df52561@pumpkin \
    --to=david.laight.linux@gmail.com \
    --cc=bp@alien8.de \
    --cc=chang.seok.bae@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@orcam.me.uk \
    --cc=mingo@redhat.com \
    --cc=sohil.mehta@intel.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox