* [PATCH] iio: humidity: htu21: Fix checkpatch tabstop warn
@ 2026-08-02 1:33 Adi Nata
2026-08-02 17:04 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Adi Nata @ 2026-08-02 1:33 UTC (permalink / raw)
To: jic23, dlechner, nuno.sa, andy, u.kleine-koenig,
adinata.softwareengineer, dakr, bhelgaas, linux-iio, linux-kernel
Cc: linux-kernel-mentees
Checkpatch warning:
WARNING:TABSTOP: Statements should start on a tabstop
+ }
WARNING:TABSTOP: Statements should start on a tabstop
+ }
Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
---
drivers/iio/humidity/htu21.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/humidity/htu21.c b/drivers/iio/humidity/htu21.c
index a9dbf08b4f1a..908661c64eb9 100644
--- a/drivers/iio/humidity/htu21.c
+++ b/drivers/iio/humidity/htu21.c
@@ -105,12 +105,12 @@ static const struct iio_chan_spec htu21_channels[] = {
.type = IIO_TEMP,
.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_PROCESSED),
.info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ),
- },
+ },
{
.type = IIO_HUMIDITYRELATIVE,
.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_PROCESSED),
.info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ),
- }
+ }
};
/*
@@ -122,7 +122,7 @@ static const struct iio_chan_spec ms8607_channels[] = {
.type = IIO_HUMIDITYRELATIVE,
.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_PROCESSED),
.info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ),
- }
+ }
};
static ssize_t htu21_show_battery_low(struct device *dev,
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio: humidity: htu21: Fix checkpatch tabstop warn
2026-08-02 1:33 [PATCH] iio: humidity: htu21: Fix checkpatch tabstop warn Adi Nata
@ 2026-08-02 17:04 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2026-08-02 17:04 UTC (permalink / raw)
To: Adi Nata
Cc: dlechner, nuno.sa, andy, u.kleine-koenig, dakr, bhelgaas,
linux-iio, linux-kernel, linux-kernel-mentees
On Sun, 2 Aug 2026 09:33:31 +0800
Adi Nata <adinata.softwareengineer@gmail.com> wrote:
> Checkpatch warning:
>
> WARNING:TABSTOP: Statements should start on a tabstop
> + }
>
> WARNING:TABSTOP: Statements should start on a tabstop
> + }
That's an amusingly uninformative set of warnings. I'm guessing
you cropped out the bit that says 'where' those are?
Anyhow, I'd not bother with what checkpatch printed for this.
Instead just say what the change is and that checkpatch suggested it.
Thanks
Jonathan
>
> Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
> ---
> drivers/iio/humidity/htu21.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/humidity/htu21.c b/drivers/iio/humidity/htu21.c
> index a9dbf08b4f1a..908661c64eb9 100644
> --- a/drivers/iio/humidity/htu21.c
> +++ b/drivers/iio/humidity/htu21.c
> @@ -105,12 +105,12 @@ static const struct iio_chan_spec htu21_channels[] = {
> .type = IIO_TEMP,
> .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_PROCESSED),
> .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ),
> - },
> + },
> {
> .type = IIO_HUMIDITYRELATIVE,
> .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_PROCESSED),
> .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ),
> - }
> + }
> };
>
> /*
> @@ -122,7 +122,7 @@ static const struct iio_chan_spec ms8607_channels[] = {
> .type = IIO_HUMIDITYRELATIVE,
> .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_PROCESSED),
> .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ),
> - }
> + }
> };
>
> static ssize_t htu21_show_battery_low(struct device *dev,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-02 17:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-02 1:33 [PATCH] iio: humidity: htu21: Fix checkpatch tabstop warn Adi Nata
2026-08-02 17:04 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox