The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Chao Yu <chao@kernel.org>
Subject: [PATCH v2 10/12] f2fs: cache: support fault injection
Date: Mon, 24 Aug 2026 21:47:29 +0800	[thread overview]
Message-ID: <20260824134731.3704352-11-chao@kernel.org> (raw)
In-Reply-To: <20260824134731.3704352-1-chao@kernel.org>

This patch adds fault injection support for metadata cache allocations
to improve error-path test coverage.
- it integrates entry allocations with FAULT_KALLOC

Signed-off-by: Chao Yu <chao@kernel.org>
---
 fs/f2fs/cache.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/fs/f2fs/cache.c b/fs/f2fs/cache.c
index 77b40a98380c..9a9d62283ae0 100644
--- a/fs/f2fs/cache.c
+++ b/fs/f2fs/cache.c
@@ -176,20 +176,24 @@ static struct f2fs_cached_block *f2fs_create_cache(
 		struct f2fs_cached_block_list *cache,
 		unsigned long index, bool nofail)
 {
+	struct f2fs_sb_info *sbi = cache->sbi;
 	struct f2fs_cached_block *entry;
 	unsigned int flags = GFP_NOFS;
 
-	if (nofail)
+	if (nofail) {
 		flags |= __GFP_NOFAIL;
-
-	entry = kzalloc_obj(*entry, flags);
-	if (!entry)
-		return ERR_PTR(-ENOMEM);
-
-	entry->data = kmalloc(cache->sbi->blocksize, flags);
-	if (!entry->data) {
-		kfree(entry);
-		return ERR_PTR(-ENOMEM);
+		entry = kzalloc_obj(*entry, flags);
+		entry->data = kmalloc(sbi->blocksize, flags);
+	} else {
+		entry = f2fs_kzalloc(sbi, sizeof(*entry), flags);
+		if (!entry)
+			return ERR_PTR(-ENOMEM);
+
+		entry->data = f2fs_kmalloc(sbi, sbi->blocksize, flags);
+		if (!entry->data) {
+			kfree(entry);
+			return ERR_PTR(-ENOMEM);
+		}
 	}
 
 	entry->index = index;
-- 
2.49.0


  parent reply	other threads:[~2026-08-24 13:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 13:47 [PATCH] f2fs: introduce metadata cache Chao Yu
2026-08-24 13:47 ` [PATCH v2 01/12] f2fs: cache: implement " Chao Yu
2026-08-25  5:39   ` Wenjie Qi
2026-08-25  6:35     ` Chao Yu
2026-08-24 13:47 ` [PATCH v2 02/12] f2fs: cache: initialize meta cache Chao Yu
2026-08-24 13:47 ` [PATCH v2 03/12] f2fs: cache: introduce shrinker Chao Yu
2026-08-25  5:42   ` Wenjie Qi
2026-08-25  6:36     ` Chao Yu
2026-08-25  5:42   ` Wenjie Qi
2026-08-25  6:37     ` Chao Yu
2026-08-24 13:47 ` [PATCH v2 04/12] f2fs: cache: introduce writeback thread Chao Yu
2026-08-24 13:47 ` [PATCH v2 05/12] f2fs: cache: use meta cache Chao Yu
2026-08-25  5:42   ` Wenjie Qi
2026-08-25  6:37     ` Chao Yu
2026-08-24 13:47 ` [PATCH v2 06/12] f2fs: cache: initialize node cache Chao Yu
2026-08-24 13:47 ` [PATCH v2 07/12] f2fs: cache: use " Chao Yu
2026-08-25  5:43   ` Wenjie Qi
2026-08-25  6:38     ` Chao Yu
2026-08-25  5:43   ` Wenjie Qi
2026-08-25  6:40     ` Chao Yu
2026-08-24 13:47 ` [PATCH v2 08/12] f2fs: cache: initialize compress cache Chao Yu
2026-08-24 13:47 ` [PATCH v2 09/12] f2fs: cache: use " Chao Yu
2026-08-25  5:43   ` Wenjie Qi
2026-08-25  6:42     ` Chao Yu
2026-08-24 13:47 ` Chao Yu [this message]
2026-08-24 13:47 ` [PATCH v2 11/12] f2fs: cache: introduce tracepoints Chao Yu
2026-08-24 13:47 ` [PATCH v2 12/12] f2fs: cache: show per-cache usage in debugfs Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260824134731.3704352-11-chao@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox