The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Wenjie Qi <qwjhust@gmail.com>
Cc: chao@kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
	qiwenjie@xiaomi.com, linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v2 09/12] f2fs: cache: use compress cache
Date: Tue, 25 Aug 2026 14:42:09 +0800	[thread overview]
Message-ID: <1f08233f-1bbc-433a-9da9-b36157e09f3a@kernel.org> (raw)
In-Reply-To: <20260825054356.401106-1-qiwenjie@xiaomi.com>

On 8/25/26 13:43, Wenjie Qi wrote:
> Hi Chao,
> 
>> entry = f2fs_grab_cache(COMPRESS_CACHE(sbi), blkaddr,
>> 				F2FS_CACHE_LOCK_CREATE);
>> if (IS_ERR(entry))
>> 	return;
>>
>> entry->ino = ino;
> 
> and inode invalidation reads:
> 
>> if (IS_COMPRESS_CACHE(cache) && entry->ino != ino)
>> 	continue;
> 
> A newly created entry is inserted into the radix tree before
> `f2fs_grab_cache()` acquires its entry lock and returns.  Its initial `ino` is
> zero, and inode invalidation reads `entry->ino` without taking that lock.

Right, better to not change original logic.

Thanks,

  reply	other threads:[~2026-08-25  6:42 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 13:47 [PATCH] f2fs: introduce metadata cache Chao Yu
2026-08-24 13:47 ` [PATCH v2 01/12] f2fs: cache: implement " Chao Yu
2026-08-25  5:39   ` Wenjie Qi
2026-08-25  6:35     ` Chao Yu
2026-08-24 13:47 ` [PATCH v2 02/12] f2fs: cache: initialize meta cache Chao Yu
2026-08-24 13:47 ` [PATCH v2 03/12] f2fs: cache: introduce shrinker Chao Yu
2026-08-25  5:42   ` Wenjie Qi
2026-08-25  6:36     ` Chao Yu
2026-08-25  5:42   ` Wenjie Qi
2026-08-25  6:37     ` Chao Yu
2026-08-24 13:47 ` [PATCH v2 04/12] f2fs: cache: introduce writeback thread Chao Yu
2026-08-24 13:47 ` [PATCH v2 05/12] f2fs: cache: use meta cache Chao Yu
2026-08-25  5:42   ` Wenjie Qi
2026-08-25  6:37     ` Chao Yu
2026-08-24 13:47 ` [PATCH v2 06/12] f2fs: cache: initialize node cache Chao Yu
2026-08-24 13:47 ` [PATCH v2 07/12] f2fs: cache: use " Chao Yu
2026-08-25  5:43   ` Wenjie Qi
2026-08-25  6:38     ` Chao Yu
2026-08-25  5:43   ` Wenjie Qi
2026-08-25  6:40     ` Chao Yu
2026-08-24 13:47 ` [PATCH v2 08/12] f2fs: cache: initialize compress cache Chao Yu
2026-08-24 13:47 ` [PATCH v2 09/12] f2fs: cache: use " Chao Yu
2026-08-25  5:43   ` Wenjie Qi
2026-08-25  6:42     ` Chao Yu [this message]
2026-08-24 13:47 ` [PATCH v2 10/12] f2fs: cache: support fault injection Chao Yu
2026-08-24 13:47 ` [PATCH v2 11/12] f2fs: cache: introduce tracepoints Chao Yu
2026-08-24 13:47 ` [PATCH v2 12/12] f2fs: cache: show per-cache usage in debugfs Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f08233f-1bbc-433a-9da9-b36157e09f3a@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qiwenjie@xiaomi.com \
    --cc=qwjhust@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox