The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Yixun Lan <dlan@kernel.org>
Cc: Bruno Banelli <bbanelli@gmail.com>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Conor Dooley <conor.dooley@microchip.com>,
	Alex Elder <elder@riscstar.com>,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: defconfig: enable dwc3 and the SpacemiT K1 thermal sensor
Date: Wed, 26 Aug 2026 09:33:10 +0100	[thread overview]
Message-ID: <20260826-ought-tableware-73678af4dd1f@spud> (raw)
In-Reply-To: <20260825224905-GKD631715@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]

On Tue, Aug 25, 2026 at 10:49:05PM +0000, Yixun Lan wrote:
> Hi Bruno,
> 
> On 07:22 Tue 25 Aug     , Bruno Banelli wrote:
> > Two blocks on SpacemiT K1 boards are unreachable from a stock defconfig
> > build:
> > 
> >  - USB_DWC3 is not enabled, so the dwc3 controller that drives all of
> >    the USB 3.0 ports on boards like the Milk-V Jupiter never probes.
> > 
> >  - SPACEMIT_K1_TSENSOR has no default in its Kconfig and is not listed
> >    here, so a K1 board comes up with no temperature readings at all,
> >    even though k1.dtsi describes five thermal zones.
> > 
> > Enable both.
> > 
> The patch itself looks good to me, but since it deal with two diferent drivers
> So, can you split it into two patches? which easy to review and manage

IMO it's fine being one patch, but this temp sensor should probably be a
module?

> 
> > Signed-off-by: Bruno Banelli <bbanelli@gmail.com>
> > ---
> >  arch/riscv/configs/defconfig | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> > index 04ae305d5..03d9ac2f7 100644
> > --- a/arch/riscv/configs/defconfig
> > +++ b/arch/riscv/configs/defconfig
> > @@ -209,6 +209,8 @@ CONFIG_USB=y
> >  CONFIG_USB_OTG=y
> >  CONFIG_USB_XHCI_HCD=y
> >  CONFIG_USB_XHCI_PLATFORM=y
> > +CONFIG_USB_DWC3=y
> > +CONFIG_USB_DWC3_GENERIC_PLAT=y
> >  CONFIG_USB_EHCI_HCD=y
> >  CONFIG_USB_EHCI_HCD_PLATFORM=y
> >  CONFIG_USB_OHCI_HCD=y
> > @@ -260,6 +262,7 @@ CONFIG_CLK_SOPHGO_SG2042_PLL=y
> >  CONFIG_CLK_SOPHGO_SG2042_CLKGEN=y
> >  CONFIG_CLK_SOPHGO_SG2042_RPGATE=y
> >  CONFIG_SPACEMIT_K1_CCU=y
> > +CONFIG_SPACEMIT_K1_TSENSOR=y
> >  CONFIG_SPACEMIT_K3_CCU=y
> >  CONFIG_SUN8I_DE2_CCU=m
> >  CONFIG_SUN50I_IOMMU=y
> > 
> > base-commit: 66498c75b4f8017f62d720d9b59675bdf3abce91
> > -- 
> > 2.43.0
> > 
> 
> -- 
> Yixun Lan (dlan)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2026-08-26  8:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  5:22 [PATCH] riscv: defconfig: enable dwc3 and the SpacemiT K1 thermal sensor Bruno Banelli
2026-08-25 22:49 ` Yixun Lan
2026-08-26  8:33   ` Conor Dooley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260826-ought-tableware-73678af4dd1f@spud \
    --to=conor@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=bbanelli@gmail.com \
    --cc=conor.dooley@microchip.com \
    --cc=dlan@kernel.org \
    --cc=elder@riscstar.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox