The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] riscv: defconfig: enable dwc3 and the SpacemiT K1 thermal sensor
@ 2026-08-25  5:22 Bruno Banelli
  2026-08-25 22:49 ` Yixun Lan
  0 siblings, 1 reply; 3+ messages in thread
From: Bruno Banelli @ 2026-08-25  5:22 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou
  Cc: Alexandre Ghiti, Conor Dooley, Yixun Lan, Alex Elder, linux-riscv,
	spacemit, linux-kernel, Bruno Banelli

Two blocks on SpacemiT K1 boards are unreachable from a stock defconfig
build:

 - USB_DWC3 is not enabled, so the dwc3 controller that drives all of
   the USB 3.0 ports on boards like the Milk-V Jupiter never probes.

 - SPACEMIT_K1_TSENSOR has no default in its Kconfig and is not listed
   here, so a K1 board comes up with no temperature readings at all,
   even though k1.dtsi describes five thermal zones.

Enable both.

Signed-off-by: Bruno Banelli <bbanelli@gmail.com>
---
 arch/riscv/configs/defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
index 04ae305d5..03d9ac2f7 100644
--- a/arch/riscv/configs/defconfig
+++ b/arch/riscv/configs/defconfig
@@ -209,6 +209,8 @@ CONFIG_USB=y
 CONFIG_USB_OTG=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_PLATFORM=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_DWC3_GENERIC_PLAT=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_HCD_PLATFORM=y
 CONFIG_USB_OHCI_HCD=y
@@ -260,6 +262,7 @@ CONFIG_CLK_SOPHGO_SG2042_PLL=y
 CONFIG_CLK_SOPHGO_SG2042_CLKGEN=y
 CONFIG_CLK_SOPHGO_SG2042_RPGATE=y
 CONFIG_SPACEMIT_K1_CCU=y
+CONFIG_SPACEMIT_K1_TSENSOR=y
 CONFIG_SPACEMIT_K3_CCU=y
 CONFIG_SUN8I_DE2_CCU=m
 CONFIG_SUN50I_IOMMU=y

base-commit: 66498c75b4f8017f62d720d9b59675bdf3abce91
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] riscv: defconfig: enable dwc3 and the SpacemiT K1 thermal sensor
  2026-08-25  5:22 [PATCH] riscv: defconfig: enable dwc3 and the SpacemiT K1 thermal sensor Bruno Banelli
@ 2026-08-25 22:49 ` Yixun Lan
  2026-08-26  8:33   ` Conor Dooley
  0 siblings, 1 reply; 3+ messages in thread
From: Yixun Lan @ 2026-08-25 22:49 UTC (permalink / raw)
  To: Bruno Banelli
  Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
	Conor Dooley, Alex Elder, linux-riscv, spacemit, linux-kernel

Hi Bruno,

On 07:22 Tue 25 Aug     , Bruno Banelli wrote:
> Two blocks on SpacemiT K1 boards are unreachable from a stock defconfig
> build:
> 
>  - USB_DWC3 is not enabled, so the dwc3 controller that drives all of
>    the USB 3.0 ports on boards like the Milk-V Jupiter never probes.
> 
>  - SPACEMIT_K1_TSENSOR has no default in its Kconfig and is not listed
>    here, so a K1 board comes up with no temperature readings at all,
>    even though k1.dtsi describes five thermal zones.
> 
> Enable both.
> 
The patch itself looks good to me, but since it deal with two diferent drivers
So, can you split it into two patches? which easy to review and manage

> Signed-off-by: Bruno Banelli <bbanelli@gmail.com>
> ---
>  arch/riscv/configs/defconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> index 04ae305d5..03d9ac2f7 100644
> --- a/arch/riscv/configs/defconfig
> +++ b/arch/riscv/configs/defconfig
> @@ -209,6 +209,8 @@ CONFIG_USB=y
>  CONFIG_USB_OTG=y
>  CONFIG_USB_XHCI_HCD=y
>  CONFIG_USB_XHCI_PLATFORM=y
> +CONFIG_USB_DWC3=y
> +CONFIG_USB_DWC3_GENERIC_PLAT=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_USB_EHCI_HCD_PLATFORM=y
>  CONFIG_USB_OHCI_HCD=y
> @@ -260,6 +262,7 @@ CONFIG_CLK_SOPHGO_SG2042_PLL=y
>  CONFIG_CLK_SOPHGO_SG2042_CLKGEN=y
>  CONFIG_CLK_SOPHGO_SG2042_RPGATE=y
>  CONFIG_SPACEMIT_K1_CCU=y
> +CONFIG_SPACEMIT_K1_TSENSOR=y
>  CONFIG_SPACEMIT_K3_CCU=y
>  CONFIG_SUN8I_DE2_CCU=m
>  CONFIG_SUN50I_IOMMU=y
> 
> base-commit: 66498c75b4f8017f62d720d9b59675bdf3abce91
> -- 
> 2.43.0
> 

-- 
Yixun Lan (dlan)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] riscv: defconfig: enable dwc3 and the SpacemiT K1 thermal sensor
  2026-08-25 22:49 ` Yixun Lan
@ 2026-08-26  8:33   ` Conor Dooley
  0 siblings, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2026-08-26  8:33 UTC (permalink / raw)
  To: Yixun Lan
  Cc: Bruno Banelli, Paul Walmsley, Palmer Dabbelt, Albert Ou,
	Alexandre Ghiti, Conor Dooley, Alex Elder, linux-riscv, spacemit,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]

On Tue, Aug 25, 2026 at 10:49:05PM +0000, Yixun Lan wrote:
> Hi Bruno,
> 
> On 07:22 Tue 25 Aug     , Bruno Banelli wrote:
> > Two blocks on SpacemiT K1 boards are unreachable from a stock defconfig
> > build:
> > 
> >  - USB_DWC3 is not enabled, so the dwc3 controller that drives all of
> >    the USB 3.0 ports on boards like the Milk-V Jupiter never probes.
> > 
> >  - SPACEMIT_K1_TSENSOR has no default in its Kconfig and is not listed
> >    here, so a K1 board comes up with no temperature readings at all,
> >    even though k1.dtsi describes five thermal zones.
> > 
> > Enable both.
> > 
> The patch itself looks good to me, but since it deal with two diferent drivers
> So, can you split it into two patches? which easy to review and manage

IMO it's fine being one patch, but this temp sensor should probably be a
module?

> 
> > Signed-off-by: Bruno Banelli <bbanelli@gmail.com>
> > ---
> >  arch/riscv/configs/defconfig | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> > index 04ae305d5..03d9ac2f7 100644
> > --- a/arch/riscv/configs/defconfig
> > +++ b/arch/riscv/configs/defconfig
> > @@ -209,6 +209,8 @@ CONFIG_USB=y
> >  CONFIG_USB_OTG=y
> >  CONFIG_USB_XHCI_HCD=y
> >  CONFIG_USB_XHCI_PLATFORM=y
> > +CONFIG_USB_DWC3=y
> > +CONFIG_USB_DWC3_GENERIC_PLAT=y
> >  CONFIG_USB_EHCI_HCD=y
> >  CONFIG_USB_EHCI_HCD_PLATFORM=y
> >  CONFIG_USB_OHCI_HCD=y
> > @@ -260,6 +262,7 @@ CONFIG_CLK_SOPHGO_SG2042_PLL=y
> >  CONFIG_CLK_SOPHGO_SG2042_CLKGEN=y
> >  CONFIG_CLK_SOPHGO_SG2042_RPGATE=y
> >  CONFIG_SPACEMIT_K1_CCU=y
> > +CONFIG_SPACEMIT_K1_TSENSOR=y
> >  CONFIG_SPACEMIT_K3_CCU=y
> >  CONFIG_SUN8I_DE2_CCU=m
> >  CONFIG_SUN50I_IOMMU=y
> > 
> > base-commit: 66498c75b4f8017f62d720d9b59675bdf3abce91
> > -- 
> > 2.43.0
> > 
> 
> -- 
> Yixun Lan (dlan)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-26  8:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-25  5:22 [PATCH] riscv: defconfig: enable dwc3 and the SpacemiT K1 thermal sensor Bruno Banelli
2026-08-25 22:49 ` Yixun Lan
2026-08-26  8:33   ` Conor Dooley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox