* [PATCH] staging: nvec: replace led_classdev_register
@ 2016-01-21 10:23 Gujulan Elango, Hari Prasath (H.)
2016-01-25 21:00 ` Marc Dietrich
0 siblings, 1 reply; 2+ messages in thread
From: Gujulan Elango, Hari Prasath (H.) @ 2016-01-21 10:23 UTC (permalink / raw)
To: gregkh@linuxfoundation.org, marvin24@gmx.de,
ac100@lists.launchpad.net
Cc: devel@driverdev.osuosl.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
From: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
Replace the led_classdev_register() with the platform managed version
devm_led_classdev_register() & henceforth remove the redundant
nvec_paz00_remove() function.
Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
---
drivers/staging/nvec/nvec_paz00.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/nvec/nvec_paz00.c b/drivers/staging/nvec/nvec_paz00.c
index 68146bf..cddbfd2 100644
--- a/drivers/staging/nvec/nvec_paz00.c
+++ b/drivers/staging/nvec/nvec_paz00.c
@@ -63,7 +63,7 @@ static int nvec_paz00_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, led);
- ret = led_classdev_register(&pdev->dev, &led->cdev);
+ ret = devm_led_classdev_register(&pdev->dev, &led->cdev);
if (ret < 0)
return ret;
@@ -73,18 +73,8 @@ static int nvec_paz00_probe(struct platform_device *pdev)
return 0;
}
-static int nvec_paz00_remove(struct platform_device *pdev)
-{
- struct nvec_led *led = platform_get_drvdata(pdev);
-
- led_classdev_unregister(&led->cdev);
-
- return 0;
-}
-
static struct platform_driver nvec_paz00_driver = {
.probe = nvec_paz00_probe,
- .remove = nvec_paz00_remove,
.driver = {
.name = "nvec-paz00",
},
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: nvec: replace led_classdev_register
2016-01-21 10:23 [PATCH] staging: nvec: replace led_classdev_register Gujulan Elango, Hari Prasath (H.)
@ 2016-01-25 21:00 ` Marc Dietrich
0 siblings, 0 replies; 2+ messages in thread
From: Marc Dietrich @ 2016-01-25 21:00 UTC (permalink / raw)
To: Gujulan Elango, Hari Prasath (H.), devel@driverdev.osuosl.org
Cc: gregkh@linuxfoundation.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]
Am Donnerstag 21 Januar 2016, 10:23:46 schrieb Gujulan Elango, Hari Prasath:
> From: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
>
> Replace the led_classdev_register() with the platform managed version
> devm_led_classdev_register() & henceforth remove the redundant
> nvec_paz00_remove() function.
>
> Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
Thanks!
Acked-by: Marc Dietrich <marvin24@gmx.de>
> ---
> drivers/staging/nvec/nvec_paz00.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec_paz00.c
> b/drivers/staging/nvec/nvec_paz00.c index 68146bf..cddbfd2 100644
> --- a/drivers/staging/nvec/nvec_paz00.c
> +++ b/drivers/staging/nvec/nvec_paz00.c
> @@ -63,7 +63,7 @@ static int nvec_paz00_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, led);
>
> - ret = led_classdev_register(&pdev->dev, &led->cdev);
> + ret = devm_led_classdev_register(&pdev->dev, &led->cdev);
> if (ret < 0)
> return ret;
>
> @@ -73,18 +73,8 @@ static int nvec_paz00_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int nvec_paz00_remove(struct platform_device *pdev)
> -{
> - struct nvec_led *led = platform_get_drvdata(pdev);
> -
> - led_classdev_unregister(&led->cdev);
> -
> - return 0;
> -}
> -
> static struct platform_driver nvec_paz00_driver = {
> .probe = nvec_paz00_probe,
> - .remove = nvec_paz00_remove,
> .driver = {
> .name = "nvec-paz00",
> },
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-25 21:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-21 10:23 [PATCH] staging: nvec: replace led_classdev_register Gujulan Elango, Hari Prasath (H.)
2016-01-25 21:00 ` Marc Dietrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox