* [PATCH] memory: tegra: Avoid double error messaging when IRQ absent
@ 2020-06-11 19:07 Keyur Patel
2020-06-12 14:15 ` Dmitry Osipenko
0 siblings, 1 reply; 2+ messages in thread
From: Keyur Patel @ 2020-06-11 19:07 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter, Dmitry Osipenko,
Peter De Schrijver, Kate Stewart, Greg Kroah-Hartman, Keyur Patel,
Thomas Gleixner, linux-tegra, linux-kernel
Since the commit 7723f4c ("driver core: platform: Add an error message
to platform_get_irq*()") platform_get_irq() started issuing an error message.
Thus, there is no need to have the same in the driver.
Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>
---
drivers/memory/tegra/mc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
index ec8403557ed4..f519c0987485 100644
--- a/drivers/memory/tegra/mc.c
+++ b/drivers/memory/tegra/mc.c
@@ -659,10 +659,8 @@ static int tegra_mc_probe(struct platform_device *pdev)
}
mc->irq = platform_get_irq(pdev, 0);
- if (mc->irq < 0) {
- dev_err(&pdev->dev, "interrupt not specified\n");
+ if (mc->irq < 0)
return mc->irq;
- }
WARN(!mc->soc->client_id_mask, "missing client ID mask for this SoC\n");
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] memory: tegra: Avoid double error messaging when IRQ absent
2020-06-11 19:07 [PATCH] memory: tegra: Avoid double error messaging when IRQ absent Keyur Patel
@ 2020-06-12 14:15 ` Dmitry Osipenko
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Osipenko @ 2020-06-12 14:15 UTC (permalink / raw)
To: Keyur Patel, Thierry Reding, Jonathan Hunter, Peter De Schrijver,
Kate Stewart, Greg Kroah-Hartman, Thomas Gleixner, linux-tegra,
linux-kernel
11.06.2020 22:07, Keyur Patel пишет:
> Since the commit 7723f4c ("driver core: platform: Add an error message
> to platform_get_irq*()") platform_get_irq() started issuing an error message.
> Thus, there is no need to have the same in the driver.
>
> Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>
> ---
> drivers/memory/tegra/mc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
> index ec8403557ed4..f519c0987485 100644
> --- a/drivers/memory/tegra/mc.c
> +++ b/drivers/memory/tegra/mc.c
> @@ -659,10 +659,8 @@ static int tegra_mc_probe(struct platform_device *pdev)
> }
>
> mc->irq = platform_get_irq(pdev, 0);
> - if (mc->irq < 0) {
> - dev_err(&pdev->dev, "interrupt not specified\n");
> + if (mc->irq < 0)
> return mc->irq;
> - }
>
> WARN(!mc->soc->client_id_mask, "missing client ID mask for this SoC\n");
>
>
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-12 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-11 19:07 [PATCH] memory: tegra: Avoid double error messaging when IRQ absent Keyur Patel
2020-06-12 14:15 ` Dmitry Osipenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox