* [PATCH] rust_binder: remove warning about orphan mappings
@ 2025-10-02 9:25 Alice Ryhl
2025-10-02 17:32 ` Joel Fernandes
2025-10-03 17:58 ` Carlos Llamas
0 siblings, 2 replies; 3+ messages in thread
From: Alice Ryhl @ 2025-10-02 9:25 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
Joel Fernandes, Christian Brauner, Carlos Llamas,
Suren Baghdasaryan, linux-kernel, rust-for-linux, Alice Ryhl
This condition occurs if a thread dies while processing a transaction.
We should not print anything in this scenario.
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
drivers/android/binder/process.rs | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/android/binder/process.rs b/drivers/android/binder/process.rs
index f13a747e784c84a0fb09cbf47442712106eba07c..d8c3c1ae740e0eb3bcc8aa5e7faf4291f1cb69c9 100644
--- a/drivers/android/binder/process.rs
+++ b/drivers/android/binder/process.rs
@@ -1346,10 +1346,6 @@ fn deferred_release(self: Arc<Self>) {
.alloc
.take_for_each(|offset, size, debug_id, odata| {
let ptr = offset + address;
- pr_warn!(
- "{}: removing orphan mapping {offset}:{size}\n",
- self.pid_in_current_ns()
- );
let mut alloc =
Allocation::new(self.clone(), debug_id, offset, size, ptr, false);
if let Some(data) = odata {
---
base-commit: eafedbc7c050c44744fbdf80bdf3315e860b7513
change-id: 20251002-binder-orphan-d1bc4bcd9777
Best regards,
--
Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rust_binder: remove warning about orphan mappings
2025-10-02 9:25 [PATCH] rust_binder: remove warning about orphan mappings Alice Ryhl
@ 2025-10-02 17:32 ` Joel Fernandes
2025-10-03 17:58 ` Carlos Llamas
1 sibling, 0 replies; 3+ messages in thread
From: Joel Fernandes @ 2025-10-02 17:32 UTC (permalink / raw)
To: Alice Ryhl, Greg Kroah-Hartman
Cc: Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
Christian Brauner, Carlos Llamas, Suren Baghdasaryan,
linux-kernel, rust-for-linux
On 10/2/2025 5:25 AM, Alice Ryhl wrote:
> This condition occurs if a thread dies while processing a transaction.
> We should not print anything in this scenario.
>
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>
thanks,
- Joel
> ---
> drivers/android/binder/process.rs | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/android/binder/process.rs b/drivers/android/binder/process.rs
> index f13a747e784c84a0fb09cbf47442712106eba07c..d8c3c1ae740e0eb3bcc8aa5e7faf4291f1cb69c9 100644
> --- a/drivers/android/binder/process.rs
> +++ b/drivers/android/binder/process.rs
> @@ -1346,10 +1346,6 @@ fn deferred_release(self: Arc<Self>) {
> .alloc
> .take_for_each(|offset, size, debug_id, odata| {
> let ptr = offset + address;
> - pr_warn!(
> - "{}: removing orphan mapping {offset}:{size}\n",
> - self.pid_in_current_ns()
> - );
> let mut alloc =
> Allocation::new(self.clone(), debug_id, offset, size, ptr, false);
> if let Some(data) = odata {
>
> ---
> base-commit: eafedbc7c050c44744fbdf80bdf3315e860b7513
> change-id: 20251002-binder-orphan-d1bc4bcd9777
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rust_binder: remove warning about orphan mappings
2025-10-02 9:25 [PATCH] rust_binder: remove warning about orphan mappings Alice Ryhl
2025-10-02 17:32 ` Joel Fernandes
@ 2025-10-03 17:58 ` Carlos Llamas
1 sibling, 0 replies; 3+ messages in thread
From: Carlos Llamas @ 2025-10-03 17:58 UTC (permalink / raw)
To: Alice Ryhl
Cc: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner,
Suren Baghdasaryan, linux-kernel, rust-for-linux
On Thu, Oct 02, 2025 at 09:25:29AM +0000, Alice Ryhl wrote:
> This condition occurs if a thread dies while processing a transaction.
> We should not print anything in this scenario.
>
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
> drivers/android/binder/process.rs | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/android/binder/process.rs b/drivers/android/binder/process.rs
> index f13a747e784c84a0fb09cbf47442712106eba07c..d8c3c1ae740e0eb3bcc8aa5e7faf4291f1cb69c9 100644
> --- a/drivers/android/binder/process.rs
> +++ b/drivers/android/binder/process.rs
> @@ -1346,10 +1346,6 @@ fn deferred_release(self: Arc<Self>) {
> .alloc
> .take_for_each(|offset, size, debug_id, odata| {
> let ptr = offset + address;
> - pr_warn!(
> - "{}: removing orphan mapping {offset}:{size}\n",
> - self.pid_in_current_ns()
> - );
> let mut alloc =
> Allocation::new(self.clone(), debug_id, offset, size, ptr, false);
> if let Some(data) = odata {
>
LGTM!
Acked-by: Carlos Llamas <cmllamas@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-03 17:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-02 9:25 [PATCH] rust_binder: remove warning about orphan mappings Alice Ryhl
2025-10-02 17:32 ` Joel Fernandes
2025-10-03 17:58 ` Carlos Llamas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox