From: Joshua Clayton <stillcompiling@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Tue, 28 Jul 2015 05:27:41 -0700 [thread overview]
Message-ID: <3309030.zsCfj96v3x@diplodocus> (raw)
In-Reply-To: <20150728114656.GF15027@sudip-pc>
On Tuesday, July 28, 2015 05:16:56 PM Sudip Mukherjee wrote:
> On Mon, Jul 27, 2015 at 09:41:10PM -0700, Joshua Clayton wrote:
> > r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
> > where the underlying struct has a 6 * unsigned char.
> > Simplify the calculation by just subtracting the variable part from
> > the size of the struct.
> >
> > This also gets rid of a use of typedef NDIS_802_11_RATES_EX
> >
> > Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
> > ---
> <snip>
> >
> > u8 *r8712_get_capability_from_ie(u8 *ie)
>
> Something is wrong. The same patch is getting repeated in the same mail
> multiple times. I deleted almost 2500 lines after this before sending
> this reply. See how your patch is looking like:
> http://www.gossamer-threads.com/lists/linux/kernel/2224869
>
> regards
> sudip
>
Oh No!
I made a tweak to git-send-email to try to get past the problem with perl 5.22
That was causing git-send-email to crash.
The whole series, including the cover letter is like this.
I will resubmit when I have fixed this problem.
next prev parent reply other threads:[~2015-07-28 12:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation Joshua Clayton
2015-07-28 11:46 ` Sudip Mukherjee
2015-07-28 12:27 ` Joshua Clayton [this message]
2015-07-28 4:41 ` [PATCH V3 2/8] staging: rtl8712: simplify " Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 3/8] staging: rtl8712: fix comment Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 7/8] staging: rtl8712: remove typedefs Joshua Clayton
2015-07-28 5:27 ` [PATCH V3 0/8] clean up wlan_bssdef.h Julia Lawall
2015-07-28 12:38 ` Joshua Clayton
2015-07-28 14:15 ` [PATCH V3 RESEND 5/8] staging: rtl8712: remove duplicate struct Joshua Clayton
2015-07-28 14:15 ` [PATCH V3 RESEND 6/8] staging: rtl8712: rename function Joshua Clayton
2015-07-28 14:16 ` [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates Joshua Clayton
2015-07-28 15:37 ` Julia Lawall
2015-07-28 15:50 ` Joshua Clayton
2015-07-28 15:53 ` Julia Lawall
2015-07-28 15:56 ` Dan Carpenter
2015-07-28 17:49 ` Joshua Clayton
2015-07-28 22:07 ` Dan Carpenter
2015-07-29 13:49 ` [PATCH V4 1/8] staging: rtl8712: fix buggy size calculation Joshua Clayton
2015-07-29 13:49 ` [PATCH V4 2/8] staging: rtl8712: simplify " Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 3/8] staging: rtl8712: fix comment Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 4/8] staging: rtl8712: removed unused wrapper structs Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 5/8] staging: rtl8712: remove duplicate struct Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 6/8] staging: rtl8712: rename function Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 7/8] staging: rtl8712: remove typedefs Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 8/8] staging: rtl8712: change SupportedRates to rates Joshua Clayton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3309030.zsCfj96v3x@diplodocus \
--to=stillcompiling@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=aysemelikeyurtoglu@gmail.com \
--cc=cristina.opriceana@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel.baluta@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dogukan.ergun@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahfouz.saif.elyazal@gmail.com \
--cc=mperepelitsyn@gmail.com \
--cc=nitinkuppelur@gmail.com \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=sudipm.mukherjee@gmail.com \
--cc=tapaswenipathak@gmail.com \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox