From: Paolo Abeni <pabeni@redhat.com>
To: Satish Kharat <satishkh@cisco.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sesidhar Baddela <sebaddel@cisco.com>
Subject: Re: [PATCH net-next v6 04/10] enic: add admin CQ service with MSI-X interrupt and NAPI polling
Date: Thu, 7 May 2026 10:03:21 +0200 [thread overview]
Message-ID: <3317a78d-de64-4df5-b132-454b4e00a42a@redhat.com> (raw)
In-Reply-To: <20260503-enic-sriov-v2-admin-channel-v2-v6-4-0af4fbc2d86d@cisco.com>
On 5/3/26 1:22 PM, Satish Kharat wrote:
> +static void enic_admin_msg_enqueue(struct enic *enic, void *buf,
> + unsigned int len)
> +{
> + struct enic_admin_msg *msg;
> +
> + msg = kmalloc(struct_size(msg, data, len), GFP_ATOMIC);
> + if (!msg) {
> + enic->admin_msg_drop_cnt++;
> + if (net_ratelimit())
> + netdev_warn(enic->netdev,
> + "admin msg enqueue drop (len=%u drops=%llu)\n",
> + len, enic->admin_msg_drop_cnt);
Failed allocation will splat dmesg; no need to added additional error
messages (here and elsewhere in the series).
/P
next prev parent reply other threads:[~2026-05-07 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260503-enic-sriov-v2-admin-channel-v2-v6-0-0af4fbc2d86d@cisco.com>
2026-05-06 16:19 ` [PATCH net-next v6 00/10] enic: SR-IOV V2 admin channel and MBOX protocol Simon Horman
[not found] ` <20260503-enic-sriov-v2-admin-channel-v2-v6-4-0af4fbc2d86d@cisco.com>
2026-05-07 8:03 ` Paolo Abeni [this message]
2026-05-07 8:06 ` [PATCH net-next v6 04/10] enic: add admin CQ service with MSI-X interrupt and NAPI polling Paolo Abeni
2026-05-07 9:42 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3317a78d-de64-4df5-b132-454b4e00a42a@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox