From: Paolo Abeni <pabeni@redhat.com>
To: Satish Kharat <satishkh@cisco.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sesidhar Baddela <sebaddel@cisco.com>
Subject: Re: [PATCH net-next v6 04/10] enic: add admin CQ service with MSI-X interrupt and NAPI polling
Date: Thu, 7 May 2026 10:06:24 +0200 [thread overview]
Message-ID: <dd67b956-b06b-4ebc-8688-ccb5c17c9d61@redhat.com> (raw)
In-Reply-To: <20260503-enic-sriov-v2-admin-channel-v2-v6-4-0af4fbc2d86d@cisco.com>
On 5/3/26 1:22 PM, Satish Kharat wrote:
> @@ -197,13 +429,47 @@ static void enic_admin_free_resources(struct enic *enic)
>
> static void enic_admin_init_resources(struct enic *enic)
> {
> + unsigned int intr_offset = enic->admin_intr_index;
> +
> vnic_wq_init(&enic->admin_wq, 0, 0, 0);
> vnic_rq_init(&enic->admin_rq, 1, 0, 0);
> - vnic_cq_init(&enic->admin_cq[0], 0, 1, 0, 0, 1, 0, 1, 0, 0, 0);
> - vnic_cq_init(&enic->admin_cq[1], 0, 1, 0, 0, 1, 0, 1, 0, 0, 0);
> + vnic_cq_init(&enic->admin_cq[0],
> + 0 /* flow_control_enable */,
Replacing magic numbers with macro with significant names would make the
code more readable with no need for additional comments.
/P
next prev parent reply other threads:[~2026-05-07 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260503-enic-sriov-v2-admin-channel-v2-v6-0-0af4fbc2d86d@cisco.com>
2026-05-06 16:19 ` [PATCH net-next v6 00/10] enic: SR-IOV V2 admin channel and MBOX protocol Simon Horman
[not found] ` <20260503-enic-sriov-v2-admin-channel-v2-v6-4-0af4fbc2d86d@cisco.com>
2026-05-07 8:03 ` [PATCH net-next v6 04/10] enic: add admin CQ service with MSI-X interrupt and NAPI polling Paolo Abeni
2026-05-07 8:06 ` Paolo Abeni [this message]
2026-05-07 9:42 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd67b956-b06b-4ebc-8688-ccb5c17c9d61@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox