* [BUG cpufreq] Invalid argument on writing to scaling_governor
@ 2014-08-01 10:43 Fengguang Wu
2014-08-01 10:46 ` Prarit Bhargava
0 siblings, 1 reply; 3+ messages in thread
From: Fengguang Wu @ 2014-08-01 10:43 UTC (permalink / raw)
To: Prarit Bhargava; +Cc: Rafael J. Wysocki, Aaron Lu, LKML
Hi Prarit,
I noticed that commit dbcbfe6aa0d61ae5e13cab43b30802482007c199 ("cpufreq: hold
policy->rwsem for duration of changing governors") will cause this problem:
root@nhm4 ~# echo performance > /sys/devices/system/cpu/cpu3/cpufreq/scaling_governor
-bash: echo: write error: Invalid argument
root@nhm4 ~# cat /sys/devices/system/cpu/cpu3/cpufreq/scaling_available_governors
conservative userspace powersave ondemand performance
Thanks,
Fengguang
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [BUG cpufreq] Invalid argument on writing to scaling_governor
2014-08-01 10:43 [BUG cpufreq] Invalid argument on writing to scaling_governor Fengguang Wu
@ 2014-08-01 10:46 ` Prarit Bhargava
2014-08-01 12:47 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Prarit Bhargava @ 2014-08-01 10:46 UTC (permalink / raw)
To: Fengguang Wu; +Cc: Rafael J. Wysocki, Aaron Lu, LKML
On 08/01/2014 06:43 AM, Fengguang Wu wrote:
> Hi Prarit,
>
> I noticed that commit dbcbfe6aa0d61ae5e13cab43b30802482007c199 ("cpufreq: hold
> policy->rwsem for duration of changing governors") will cause this problem:
>
> root@nhm4 ~# echo performance > /sys/devices/system/cpu/cpu3/cpufreq/scaling_governor
> -bash: echo: write error: Invalid argument
>
> root@nhm4 ~# cat /sys/devices/system/cpu/cpu3/cpufreq/scaling_available_governors
> conservative userspace powersave ondemand performance
>
Rafael, this patch needs to be rejected based on my previous comments, most
notably Saravana was able to reproduce the original problem. I'm going to wait
for his reproducer and see what I can do.
Thanks,
P.
> Thanks,
> Fengguang
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [BUG cpufreq] Invalid argument on writing to scaling_governor
2014-08-01 10:46 ` Prarit Bhargava
@ 2014-08-01 12:47 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2014-08-01 12:47 UTC (permalink / raw)
To: Prarit Bhargava; +Cc: Fengguang Wu, Rafael J. Wysocki, Aaron Lu, LKML
On Friday, August 01, 2014 06:46:51 AM Prarit Bhargava wrote:
>
> On 08/01/2014 06:43 AM, Fengguang Wu wrote:
> > Hi Prarit,
> >
> > I noticed that commit dbcbfe6aa0d61ae5e13cab43b30802482007c199 ("cpufreq: hold
> > policy->rwsem for duration of changing governors") will cause this problem:
> >
> > root@nhm4 ~# echo performance > /sys/devices/system/cpu/cpu3/cpufreq/scaling_governor
> > -bash: echo: write error: Invalid argument
> >
> > root@nhm4 ~# cat /sys/devices/system/cpu/cpu3/cpufreq/scaling_available_governors
> > conservative userspace powersave ondemand performance
> >
>
> Rafael, this patch needs to be rejected based on my previous comments, most
> notably Saravana was able to reproduce the original problem. I'm going to wait
> for his reproducer and see what I can do.
I've dropped it already. At least as far as I can say it shouldn't be there in
my linux-next branch any more. Can you double check, please?
Rafael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-01 12:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-01 10:43 [BUG cpufreq] Invalid argument on writing to scaling_governor Fengguang Wu
2014-08-01 10:46 ` Prarit Bhargava
2014-08-01 12:47 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox