From: Reinette Chatre <reinette.chatre@intel.com>
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghuay@nvidia.com>,
"Maciej Wieczor-Retman" <maciej.wieczor-retman@intel.com>,
Peter Newman <peternewman@google.com>,
James Morse <james.morse@arm.com>,
Babu Moger <babu.moger@amd.com>,
Drew Fustini <dfustini@baylibre.com>,
Dave Martin <Dave.Martin@arm.com>, Chen Yu <yu.c.chen@intel.com>,
David E Box <david.e.box@intel.com>, <x86@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
<linux-kernel@vger.kernel.org>, <patches@lists.linux.dev>
Subject: Re: [PATCH v9 10/12] fs/resctrl: Call architecture hooks for every mount/unmount
Date: Wed, 8 Jul 2026 15:53:20 -0700 [thread overview]
Message-ID: <37274b66-13b7-4ced-9d79-e52d68a7ebae@intel.com> (raw)
In-Reply-To: <20260701213553.15222-11-tony.luck@intel.com>
Hi Tony,
On 7/1/26 2:35 PM, Tony Luck wrote:
> The intel_pmt module should only be pinned while the resctrl file system
> is mounted.
>
> Add hooks for every mount/unmount of the resctrl file system so that
> architecture code can increment the intel_pmt module reference count on
> mount and decrement on unmount.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
> @@ -3168,6 +3167,8 @@ static void resctrl_unmount(void)
> resctrl_mounted = false;
> mutex_unlock(&rdtgroup_mutex);
> cpus_read_unlock();
> +
> + resctrl_arch_unmount();
> }
>
> static int rdt_get_tree(struct fs_context *fc)
> @@ -3179,7 +3180,7 @@ static int rdt_get_tree(struct fs_context *fc)
> struct rdt_resource *r;
> int ret;
>
> - DO_ONCE_SLEEPABLE(resctrl_arch_pre_mount);
> + resctrl_arch_pre_mount();
>
> cpus_read_lock();
> mutex_lock(&rdtgroup_mutex);
> @@ -3318,6 +3319,9 @@ static int rdt_get_tree(struct fs_context *fc)
> out:
> mutex_unlock(&rdtgroup_mutex);
> cpus_read_unlock();
> +
> + resctrl_arch_unmount();
> +
> return ret;
> }
>
rdt_get_tree() jumps to "out" if resctrl is already mounted - in this scenario
resctrl fs is mounted and the telemetry events exposed to user space. Above would
cause telemetry to be yanked from underneath an existing mount?
Reinette
next prev parent reply other threads:[~2026-07-08 22:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 21:35 [PATCH v9 00/12] Allow AET to use PMT as loadable module Tony Luck
2026-07-01 21:35 ` [PATCH v9 01/12] platform/x86/intel/{pmt,vsec}: Prevent unbind via sysfs Tony Luck
2026-07-08 22:45 ` Reinette Chatre
2026-07-09 17:41 ` Luck, Tony
2026-07-09 20:48 ` Reinette Chatre
2026-07-09 21:12 ` Luck, Tony
2026-07-10 17:01 ` Luck, Tony
2026-07-10 20:24 ` Luck, Tony
2026-07-01 21:35 ` [PATCH v9 02/12] fs/resctrl: Remove redundant calls to resctrl_arch_mon_capable() Tony Luck
2026-07-01 21:35 ` [PATCH v9 03/12] x86/resctrl: Honor rdt=perf option to force enable AET perf events Tony Luck
2026-07-08 22:46 ` Reinette Chatre
2026-07-10 20:29 ` Luck, Tony
2026-07-01 21:35 ` [PATCH v9 04/12] fs/resctrl: Add interface to disable a monitor event Tony Luck
2026-07-01 21:35 ` [PATCH v9 05/12] x86/resctrl: Drop global 'rdt_mon_capable' flag Tony Luck
2026-07-08 22:47 ` Reinette Chatre
2026-07-10 20:31 ` Luck, Tony
2026-07-01 21:35 ` [PATCH v9 06/12] arm,x86,fs/resctrl: Handle change in number of RMIDs on each mount Tony Luck
2026-07-08 22:50 ` Reinette Chatre
2026-07-10 20:51 ` Luck, Tony
2026-07-01 21:35 ` [PATCH v9 07/12] x86/resctrl: Add PMT registration API for AET enumeration callbacks Tony Luck
2026-07-08 22:51 ` Reinette Chatre
2026-07-10 20:54 ` Luck, Tony
2026-07-01 21:35 ` [PATCH v9 08/12] platform/x86/intel/pmt: Register enumeration functions with resctrl Tony Luck
2026-07-01 21:35 ` [PATCH v9 09/12] arm,x86/resctrl: Resolve INTEL_PMT_TELEMETRY symbols at runtime Tony Luck
2026-07-08 22:52 ` Reinette Chatre
2026-07-10 20:59 ` Luck, Tony
2026-07-01 21:35 ` [PATCH v9 10/12] fs/resctrl: Call architecture hooks for every mount/unmount Tony Luck
2026-07-08 22:53 ` Reinette Chatre [this message]
2026-07-10 21:01 ` Luck, Tony
2026-07-01 21:35 ` [PATCH v9 11/12] x86/resctrl: Simplify Kconfig options for resctrl Tony Luck
2026-07-08 23:01 ` Reinette Chatre
2026-07-10 21:08 ` Luck, Tony
2026-07-01 21:35 ` [PATCH v9 12/12] Documentation/filesystems/resctrl: Document telemetry mount timing caveat Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37274b66-13b7-4ced-9d79-e52d68a7ebae@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=david.e.box@intel.com \
--cc=dfustini@baylibre.com \
--cc=fenghuay@nvidia.com \
--cc=hch@infradead.org \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox