From: Arnd Bergmann <arnd@arndb.de>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Oded Gabbay <oded.gabbay@amd.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org
Subject: Re: [RFC][PATCH] amdkfd: Convert timestamping to use 64bit time accessors
Date: Fri, 13 Mar 2015 12:24:27 +0100 [thread overview]
Message-ID: <3959463.EVBM1FXcuD@wuerfel> (raw)
In-Reply-To: <1426181020-2344-1-git-send-email-john.stultz@linaro.org>
On Thursday 12 March 2015 10:23:40 John Stultz wrote:
> Convert the timestamping in the amdkfd driver to use
> a timespec64 and 64bit time accessors.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Oded Gabbay <oded.gabbay@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: John Stultz <john.stultz@linaro.org>
>
The patch looks good, but I'd always include at least a one-liner
about what it's good for. In this case, the existing code
is completely safe beyond y2038 because you are dealing with
monotonic time, so it's worth mentioning that we do this in
order to kill off all uses of struct timespec.
Arnd
next prev parent reply other threads:[~2015-03-13 11:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 17:23 [RFC][PATCH] amdkfd: Convert timestamping to use 64bit time accessors John Stultz
2015-03-13 11:24 ` Arnd Bergmann [this message]
2015-03-19 8:29 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3959463.EVBM1FXcuD@wuerfel \
--to=arnd@arndb.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oded.gabbay@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox