[RFC][PATCH] amdkfd: Convert timestamping to use 64bit time accessors

[RFC][PATCH] amdkfd: Convert timestamping to use 64bit time accessors

[John Stultz]

Convert the timestamping in the amdkfd driver to use
a timespec64 and 64bit time accessors.

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Oded Gabbay <oded.gabbay@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
index 5c50aa8..50fc8ba 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
@@ -435,7 +435,7 @@ static int kfd_ioctl_get_clock_counters(struct file *filep,
 {
 	struct kfd_ioctl_get_clock_counters_args *args = data;
 	struct kfd_dev *dev;
-	struct timespec time;
+	struct timespec64 time;
 
 	dev = kfd_device_by_id(args->gpu_id);
 	if (dev == NULL)
@@ -445,11 +445,11 @@ static int kfd_ioctl_get_clock_counters(struct file *filep,
 	args->gpu_clock_counter = kfd2kgd->get_gpu_clock_counter(dev->kgd);
 
 	/* No access to rdtsc. Using raw monotonic time */
-	getrawmonotonic(&time);
-	args->cpu_clock_counter = (uint64_t)timespec_to_ns(&time);
+	getrawmonotonic64(&time);
+	args->cpu_clock_counter = (uint64_t)timespec64_to_ns(&time);
 
-	get_monotonic_boottime(&time);
-	args->system_clock_counter = (uint64_t)timespec_to_ns(&time);
+	get_monotonic_boottime64(&time);
+	args->system_clock_counter = (uint64_t)timespec64_to_ns(&time);
 
 	/* Since the counter is in nano-seconds we use 1GHz frequency */
 	args->system_clock_freq = 1000000000;
-- 
1.9.1

Re: [RFC][PATCH] amdkfd: Convert timestamping to use 64bit time accessors

[Arnd Bergmann]

On Thursday 12 March 2015 10:23:40 John Stultz wrote:
> Convert the timestamping in the amdkfd driver to use
> a timespec64 and 64bit time accessors.
> 
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Oded Gabbay <oded.gabbay@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> 

The patch looks good, but I'd always include at least a one-liner
about what it's good for. In this case, the existing code
is completely safe beyond y2038 because you are dealing with
monotonic time, so it's worth mentioning that we do this in
order to kill off all uses of struct timespec.

	Arnd

Re: [RFC][PATCH] amdkfd: Convert timestamping to use 64bit time accessors

[Oded Gabbay]

On 03/13/2015 01:24 PM, Arnd Bergmann wrote:
> On Thursday 12 March 2015 10:23:40 John Stultz wrote:
>> Convert the timestamping in the amdkfd driver to use
>> a timespec64 and 64bit time accessors.
>>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Oded Gabbay <oded.gabbay@amd.com>
>> Cc: David Airlie <airlied@linux.ie>
>> Cc: dri-devel@lists.freedesktop.org
>> Signed-off-by: John Stultz <john.stultz@linaro.org>
>>
>
> The patch looks good, but I'd always include at least a one-liner
> about what it's good for. In this case, the existing code
> is completely safe beyond y2038 because you are dealing with
> monotonic time, so it's worth mentioning that we do this in
> order to kill off all uses of struct timespec.
>
> 	Arnd
>
Thanks!
Applied to my -next tree so will probably be in 4.1

	Oded