ipath uses skb functions

ipath uses skb functions

[Randy Dunlap]

but doesn't depends on NET (Networking).

drivers/built-in.o: In function `ipath_free_pddata':
(.text.ipath_free_pddata+0x155): undefined reference to `kfree_skb'
drivers/built-in.o: In function `ipath_alloc_skb':
(.text.ipath_alloc_skb+0x28): undefined reference to `__alloc_skb'
drivers/built-in.o: In function `ipath_init_chip':
(.text.ipath_init_chip+0xe61): undefined reference to `kfree_skb'
make: *** [vmlinux] Error 1

2.6.19-rc6-git2

---
~Randy

Re: ipath uses skb functions

[Bryan O'Sullivan]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

Randy Dunlap wrote:
> but doesn't depends on NET (Networking).

Thanks.  One-liner patch attached.  Roland, please add this to your 
for-2.6.19 or for-2.6.20 queue, as you see fit.

	<b

[-- Attachment #2: ipath-config-net.patch --]
[-- Type: text/x-patch, Size: 700 bytes --]

IB/ipath - make Kconfig depend on CONFIG_NET

Spotted by Randy Dunlap.

Signed-off-by: Bryan O'Sullivan <bryan.osullivan@qlogic.com>

diff -r 9769053d8f77 drivers/infiniband/hw/ipath/Kconfig
--- a/drivers/infiniband/hw/ipath/Kconfig	Tue Nov 14 10:07:29 2006 -0800
+++ b/drivers/infiniband/hw/ipath/Kconfig	Mon Nov 20 10:51:25 2006 -0800
@@ -1,6 +1,6 @@ config INFINIBAND_IPATH
 config INFINIBAND_IPATH
 	tristate "QLogic InfiniPath Driver"
-	depends on (PCI_MSI || HT_IRQ) && 64BIT && INFINIBAND
+	depends on (PCI_MSI || HT_IRQ) && 64BIT && INFINIBAND && NET
 	---help---
 	This is a driver for QLogic InfiniPath host channel adapters,
 	including InfiniBand verbs support.  This driver allows these

Re: ipath uses skb functions

[Randy Dunlap]

Bryan O'Sullivan wrote:
> Randy Dunlap wrote:
>> but doesn't depends on NET (Networking).
> 
> Thanks.  One-liner patch attached.  Roland, please add this to your 
> for-2.6.19 or for-2.6.20 queue, as you see fit.
> 
>     <b

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

> ------------------------------------------------------------------------
> 
> IB/ipath - make Kconfig depend on CONFIG_NET
> 
> Spotted by Randy Dunlap.
> 
> Signed-off-by: Bryan O'Sullivan <bryan.osullivan@qlogic.com>
> 
> diff -r 9769053d8f77 drivers/infiniband/hw/ipath/Kconfig
> --- a/drivers/infiniband/hw/ipath/Kconfig	Tue Nov 14 10:07:29 2006 -0800
> +++ b/drivers/infiniband/hw/ipath/Kconfig	Mon Nov 20 10:51:25 2006 -0800
> @@ -1,6 +1,6 @@ config INFINIBAND_IPATH
>  config INFINIBAND_IPATH
>  	tristate "QLogic InfiniPath Driver"
> -	depends on (PCI_MSI || HT_IRQ) && 64BIT && INFINIBAND
> +	depends on (PCI_MSI || HT_IRQ) && 64BIT && INFINIBAND && NET
>  	---help---
>  	This is a driver for QLogic InfiniPath host channel adapters,
>  	including InfiniBand verbs support.  This driver allows these


-- 
~Randy

Re: ipath uses skb functions

[Roland Dreier]

Thanks, applied.