* ipath uses skb functions
@ 2006-11-19 20:51 Randy Dunlap
2006-11-20 18:54 ` Bryan O'Sullivan
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2006-11-19 20:51 UTC (permalink / raw)
To: lkml; +Cc: rolandd, bos
but doesn't depends on NET (Networking).
drivers/built-in.o: In function `ipath_free_pddata':
(.text.ipath_free_pddata+0x155): undefined reference to `kfree_skb'
drivers/built-in.o: In function `ipath_alloc_skb':
(.text.ipath_alloc_skb+0x28): undefined reference to `__alloc_skb'
drivers/built-in.o: In function `ipath_init_chip':
(.text.ipath_init_chip+0xe61): undefined reference to `kfree_skb'
make: *** [vmlinux] Error 1
2.6.19-rc6-git2
---
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ipath uses skb functions
2006-11-19 20:51 ipath uses skb functions Randy Dunlap
@ 2006-11-20 18:54 ` Bryan O'Sullivan
2006-11-20 19:04 ` Randy Dunlap
2006-11-20 21:05 ` Roland Dreier
0 siblings, 2 replies; 4+ messages in thread
From: Bryan O'Sullivan @ 2006-11-20 18:54 UTC (permalink / raw)
To: rdreier; +Cc: lkml, randy.dunlap, openib-general
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
Randy Dunlap wrote:
> but doesn't depends on NET (Networking).
Thanks. One-liner patch attached. Roland, please add this to your
for-2.6.19 or for-2.6.20 queue, as you see fit.
<b
[-- Attachment #2: ipath-config-net.patch --]
[-- Type: text/x-patch, Size: 700 bytes --]
IB/ipath - make Kconfig depend on CONFIG_NET
Spotted by Randy Dunlap.
Signed-off-by: Bryan O'Sullivan <bryan.osullivan@qlogic.com>
diff -r 9769053d8f77 drivers/infiniband/hw/ipath/Kconfig
--- a/drivers/infiniband/hw/ipath/Kconfig Tue Nov 14 10:07:29 2006 -0800
+++ b/drivers/infiniband/hw/ipath/Kconfig Mon Nov 20 10:51:25 2006 -0800
@@ -1,6 +1,6 @@ config INFINIBAND_IPATH
config INFINIBAND_IPATH
tristate "QLogic InfiniPath Driver"
- depends on (PCI_MSI || HT_IRQ) && 64BIT && INFINIBAND
+ depends on (PCI_MSI || HT_IRQ) && 64BIT && INFINIBAND && NET
---help---
This is a driver for QLogic InfiniPath host channel adapters,
including InfiniBand verbs support. This driver allows these
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ipath uses skb functions
2006-11-20 18:54 ` Bryan O'Sullivan
@ 2006-11-20 19:04 ` Randy Dunlap
2006-11-20 21:05 ` Roland Dreier
1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2006-11-20 19:04 UTC (permalink / raw)
To: Bryan O'Sullivan; +Cc: rdreier, lkml, openib-general
Bryan O'Sullivan wrote:
> Randy Dunlap wrote:
>> but doesn't depends on NET (Networking).
>
> Thanks. One-liner patch attached. Roland, please add this to your
> for-2.6.19 or for-2.6.20 queue, as you see fit.
>
> <b
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> ------------------------------------------------------------------------
>
> IB/ipath - make Kconfig depend on CONFIG_NET
>
> Spotted by Randy Dunlap.
>
> Signed-off-by: Bryan O'Sullivan <bryan.osullivan@qlogic.com>
>
> diff -r 9769053d8f77 drivers/infiniband/hw/ipath/Kconfig
> --- a/drivers/infiniband/hw/ipath/Kconfig Tue Nov 14 10:07:29 2006 -0800
> +++ b/drivers/infiniband/hw/ipath/Kconfig Mon Nov 20 10:51:25 2006 -0800
> @@ -1,6 +1,6 @@ config INFINIBAND_IPATH
> config INFINIBAND_IPATH
> tristate "QLogic InfiniPath Driver"
> - depends on (PCI_MSI || HT_IRQ) && 64BIT && INFINIBAND
> + depends on (PCI_MSI || HT_IRQ) && 64BIT && INFINIBAND && NET
> ---help---
> This is a driver for QLogic InfiniPath host channel adapters,
> including InfiniBand verbs support. This driver allows these
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ipath uses skb functions
2006-11-20 18:54 ` Bryan O'Sullivan
2006-11-20 19:04 ` Randy Dunlap
@ 2006-11-20 21:05 ` Roland Dreier
1 sibling, 0 replies; 4+ messages in thread
From: Roland Dreier @ 2006-11-20 21:05 UTC (permalink / raw)
To: Bryan O'Sullivan; +Cc: lkml, randy.dunlap, openib-general
Thanks, applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-11-20 21:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-19 20:51 ipath uses skb functions Randy Dunlap
2006-11-20 18:54 ` Bryan O'Sullivan
2006-11-20 19:04 ` Randy Dunlap
2006-11-20 21:05 ` Roland Dreier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox