Re: [PATCH 03/10] drm/panel/novatek-nt37700f: Use refcounted allocation in place of devm_kzalloc()

[Neil Armstrong <neil.armstrong@linaro.org>]

On 5/7/26 13:53, Albert Esteve wrote:
> Move to using the new API devm_drm_panel_alloc() to allocate the
> panel. In the call to the new API, avoid using explicit type and use
> __typeof() for more type safety.
> 
> Signed-off-by: Albert Esteve <aesteve@redhat.com>
> ---
>   drivers/gpu/drm/panel/panel-novatek-nt37700f.c | 11 ++++++-----
>   1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt37700f.c b/drivers/gpu/drm/panel/panel-novatek-nt37700f.c
> index 74f46a268c0f6..c221dd498fed4 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt37700f.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt37700f.c
> @@ -225,9 +225,12 @@ static int nt37700f_tianma_probe(struct mipi_dsi_device *dsi)
>   	struct nt37700f_tianma *ctx;
>   	int ret;
>   
> -	ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
> -	if (!ctx)
> -		return -ENOMEM;
> +	ctx = devm_drm_panel_alloc(dev, __typeof(*ctx), panel,
> +				  &nt37700f_tianma_panel_funcs,
> +				  DRM_MODE_CONNECTOR_DSI);
> +
> +	if (IS_ERR(ctx))
> +		return PTR_ERR(ctx);
>   
>   	ctx->supply = devm_regulator_get(dev, "power");
>   	if (IS_ERR(ctx->supply))
> @@ -247,8 +250,6 @@ static int nt37700f_tianma_probe(struct mipi_dsi_device *dsi)
>   	dsi->mode_flags = MIPI_DSI_MODE_VIDEO_BURST |
>   			  MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM;
>   
> -	drm_panel_init(&ctx->panel, dev, &nt37700f_tianma_panel_funcs,
> -		       DRM_MODE_CONNECTOR_DSI);
>   	ctx->panel.prepare_prev_first = true;
>   
>   	ctx->panel.backlight = nt37700f_tianma_create_backlight(dsi);
>