Re: [PATCH 09/10] drm/panel/startek-kd070fhfid015: Use refcounted allocation in place of devm_kzalloc()

[Neil Armstrong <neil.armstrong@linaro.org>]

On 5/7/26 13:53, Albert Esteve wrote:
> Move to using the new API devm_drm_panel_alloc() to allocate the
> panel. In the call to the new API, avoid using explicit type and use
> __typeof() for more type safety.
> 
> Signed-off-by: Albert Esteve <aesteve@redhat.com>
> ---
>   drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c b/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c
> index c0c95355b7435..7f04b7b404e7d 100644
> --- a/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c
> +++ b/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c
> @@ -286,9 +286,6 @@ static int stk_panel_add(struct stk_panel *stk)
>   		return ret;
>   	}
>   
> -	drm_panel_init(&stk->base, &stk->dsi->dev, &stk_panel_funcs,
> -		       DRM_MODE_CONNECTOR_DSI);
> -
>   	drm_panel_add(&stk->base);
>   
>   	return 0;
> @@ -303,9 +300,12 @@ static int stk_panel_probe(struct mipi_dsi_device *dsi)
>   	dsi->format = MIPI_DSI_FMT_RGB888;
>   	dsi->mode_flags = (MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_LPM);
>   
> -	stk = devm_kzalloc(&dsi->dev, sizeof(*stk), GFP_KERNEL);
> -	if (!stk)
> -		return -ENOMEM;
> +	stk = devm_drm_panel_alloc(&dsi->dev, __typeof(*stk), base,
> +				  &stk_panel_funcs,
> +				  DRM_MODE_CONNECTOR_DSI);
> +
> +	if (IS_ERR(stk))
> +		return PTR_ERR(stk);
>   
>   	mipi_dsi_set_drvdata(dsi, stk);
>   
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil