[PATCH] Fix comparison using wrong pointer variable in dma debug code

[PATCH] Fix comparison using wrong pointer variable in dma debug code

[Thomas Jarosch]

cppcheck reported:
[lib/dma-debug.c:248] -> [lib/dma-debug.c:248]: (style) Same expression on both sides of '=='.

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---
 lib/dma-debug.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index 74c6c7f..fea790a 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -245,7 +245,7 @@ static void put_hash_bucket(struct hash_bucket *bucket,
 
 static bool exact_match(struct dma_debug_entry *a, struct dma_debug_entry *b)
 {
-	return ((a->dev_addr == a->dev_addr) &&
+	return ((a->dev_addr == b->dev_addr) &&
 		(a->dev == b->dev)) ? true : false;
 }
 
-- 
1.7.6.4

Re: [PATCH] Fix comparison using wrong pointer variable in dma debug code

[Neil Horman]

On Thu, Nov 17, 2011 at 08:31:02PM +0100, Thomas Jarosch wrote:
> cppcheck reported:
> [lib/dma-debug.c:248] -> [lib/dma-debug.c:248]: (style) Same expression on both sides of '=='.
> 
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> ---
>  lib/dma-debug.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> index 74c6c7f..fea790a 100644
> --- a/lib/dma-debug.c
> +++ b/lib/dma-debug.c
> @@ -245,7 +245,7 @@ static void put_hash_bucket(struct hash_bucket *bucket,
>  
>  static bool exact_match(struct dma_debug_entry *a, struct dma_debug_entry *b)
>  {
> -	return ((a->dev_addr == a->dev_addr) &&
> +	return ((a->dev_addr == b->dev_addr) &&
>  		(a->dev == b->dev)) ? true : false;
>  }
>  
> -- 
> 1.7.6.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
Thanks for the catch!  Viro just pointed out you can also remove the ?
true/false changes and extraneous parens, reducing it to:

(a->dev_addr == b->dev_addr) && (a->dev == b->dev)
But its not strictly necessecary

Acked-by: Neil Horman <nhorman@tuxdriver.com>

Re: [PATCH] Fix comparison using wrong pointer variable in dma debug code

[Joe Perches]

On Thu, 2011-11-17 at 20:31 +0100, Thomas Jarosch wrote:
> cppcheck reported:
> [lib/dma-debug.c:248] -> [lib/dma-debug.c:248]: (style) Same expression on both sides of '=='.
> 
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> ---
>  lib/dma-debug.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> index 74c6c7f..fea790a 100644
> --- a/lib/dma-debug.c
> +++ b/lib/dma-debug.c
> @@ -245,7 +245,7 @@ static void put_hash_bucket(struct hash_bucket *bucket,
>  
>  static bool exact_match(struct dma_debug_entry *a, struct dma_debug_entry *b)
>  {
> -	return ((a->dev_addr == a->dev_addr) &&
> +	return ((a->dev_addr == b->dev_addr) &&
>  		(a->dev == b->dev)) ? true : false;
>  }
>  

Perhaps more sensible without the unnecessary ?:

	return a->dev_addr == b->dev_addr && a->dev == b->dev;

Re: [PATCH] Fix comparison using wrong pointer variable in dma debug code

[Thomas Jarosch]

On Thursday, 17. November 2011 21:01:36 Neil Horman wrote:
> Thanks for the catch!  Viro just pointed out you can also remove the ?
> true/false changes and extraneous parens, reducing it to:
> 
> (a->dev_addr == b->dev_addr) && (a->dev == b->dev)
> But its not strictly necessecary
> 
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

I'd say just commit the fix, that rarely used function
is not worth the extra effort.

Cheers,
Thomas

Re: [PATCH] Fix comparison using wrong pointer variable in dma debug code

[Joerg Roedel]

On Thu, Nov 17, 2011 at 08:31:02PM +0100, Thomas Jarosch wrote:
> cppcheck reported:
> [lib/dma-debug.c:248] -> [lib/dma-debug.c:248]: (style) Same expression on both sides of '=='.
> 
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>

Applied to iommu/fixes, thanks.


-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632