* [PATCH] serial/documentation: fix name of DCD cpp symbol
@ 2011-12-02 20:20 Uwe Kleine-König
2011-12-02 23:42 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2011-12-02 20:20 UTC (permalink / raw)
To: Alan Cox; +Cc: Randy Dunlap, linux-kernel
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Documentation/serial/driver | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/serial/driver b/Documentation/serial/driver
index 77ba0af..0a25a91 100644
--- a/Documentation/serial/driver
+++ b/Documentation/serial/driver
@@ -101,7 +101,7 @@ hardware.
Returns the current state of modem control inputs. The state
of the outputs should not be returned, since the core keeps
track of their state. The state information should include:
- - TIOCM_DCD state of DCD signal
+ - TIOCM_CAR state of DCD signal
- TIOCM_CTS state of CTS signal
- TIOCM_DSR state of DSR signal
- TIOCM_RI state of RI signal
--
1.7.7.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] serial/documentation: fix name of DCD cpp symbol
2011-12-02 20:20 [PATCH] serial/documentation: fix name of DCD cpp symbol Uwe Kleine-König
@ 2011-12-02 23:42 ` Alan Cox
2012-01-04 23:13 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2011-12-02 23:42 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: Randy Dunlap, linux-kernel
On Fri, 2 Dec 2011 21:20:11 +0100
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Documentation/serial/driver | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/serial/driver b/Documentation/serial/driver
> index 77ba0af..0a25a91 100644
> --- a/Documentation/serial/driver
> +++ b/Documentation/serial/driver
> @@ -101,7 +101,7 @@ hardware.
> Returns the current state of modem control inputs. The state
> of the outputs should not be returned, since the core keeps
> track of their state. The state information should include:
> - - TIOCM_DCD state of DCD signal
> + - TIOCM_CAR state of DCD signal
> - TIOCM_CTS state of CTS signal
> - TIOCM_DSR state of DSR signal
> - TIOCM_RI state of RI signal
Acked-by: Alan Cox <alan@linux.intel.com>
but please fix the Subject line to be less confusing - it sounds like
it changes the define not the docs...
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial/documentation: fix name of DCD cpp symbol
2011-12-02 23:42 ` Alan Cox
@ 2012-01-04 23:13 ` Randy Dunlap
2012-01-04 22:24 ` Greg KH
2012-01-05 0:37 ` Alan Cox
0 siblings, 2 replies; 5+ messages in thread
From: Randy Dunlap @ 2012-01-04 23:13 UTC (permalink / raw)
To: Alan Cox; +Cc: Uwe Kleine-König, linux-kernel, Greg KH
On 12/02/2011 03:42 PM, Alan Cox wrote:
> On Fri, 2 Dec 2011 21:20:11 +0100
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> ---
>> Documentation/serial/driver | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/Documentation/serial/driver b/Documentation/serial/driver
>> index 77ba0af..0a25a91 100644
>> --- a/Documentation/serial/driver
>> +++ b/Documentation/serial/driver
>> @@ -101,7 +101,7 @@ hardware.
>> Returns the current state of modem control inputs. The state
>> of the outputs should not be returned, since the core keeps
>> track of their state. The state information should include:
>> - - TIOCM_DCD state of DCD signal
>> + - TIOCM_CAR state of DCD signal
>> - TIOCM_CTS state of CTS signal
>> - TIOCM_DSR state of DSR signal
>> - TIOCM_RI state of RI signal
>
> Acked-by: Alan Cox <alan@linux.intel.com>
>
> but please fix the Subject line to be less confusing - it sounds like
> it changes the define not the docs...
(sorry for the delayed reply)
I thought that DCD meant Data Carrier Detect. Is that old? Has it changed
to just Carrier?
Greg, do you want to merge this?
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial/documentation: fix name of DCD cpp symbol
2012-01-04 23:13 ` Randy Dunlap
@ 2012-01-04 22:24 ` Greg KH
2012-01-05 0:37 ` Alan Cox
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2012-01-04 22:24 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Alan Cox, Uwe Kleine-König, linux-kernel
On Wed, Jan 04, 2012 at 03:13:29PM -0800, Randy Dunlap wrote:
> On 12/02/2011 03:42 PM, Alan Cox wrote:
> > On Fri, 2 Dec 2011 21:20:11 +0100
> > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> >
> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >> ---
> >> Documentation/serial/driver | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/Documentation/serial/driver b/Documentation/serial/driver
> >> index 77ba0af..0a25a91 100644
> >> --- a/Documentation/serial/driver
> >> +++ b/Documentation/serial/driver
> >> @@ -101,7 +101,7 @@ hardware.
> >> Returns the current state of modem control inputs. The state
> >> of the outputs should not be returned, since the core keeps
> >> track of their state. The state information should include:
> >> - - TIOCM_DCD state of DCD signal
> >> + - TIOCM_CAR state of DCD signal
> >> - TIOCM_CTS state of CTS signal
> >> - TIOCM_DSR state of DSR signal
> >> - TIOCM_RI state of RI signal
> >
> > Acked-by: Alan Cox <alan@linux.intel.com>
> >
> > but please fix the Subject line to be less confusing - it sounds like
> > it changes the define not the docs...
>
>
> (sorry for the delayed reply)
>
> I thought that DCD meant Data Carrier Detect. Is that old? Has it changed
> to just Carrier?
>
> Greg, do you want to merge this?
Sure, I can, care to bounce me the original?
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial/documentation: fix name of DCD cpp symbol
2012-01-04 23:13 ` Randy Dunlap
2012-01-04 22:24 ` Greg KH
@ 2012-01-05 0:37 ` Alan Cox
1 sibling, 0 replies; 5+ messages in thread
From: Alan Cox @ 2012-01-05 0:37 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Uwe Kleine-König, linux-kernel, Greg KH
On Wed, 04 Jan 2012 15:13:29 -0800
Randy Dunlap <rdunlap@xenotime.net> wrote:
> On 12/02/2011 03:42 PM, Alan Cox wrote:
> > On Fri, 2 Dec 2011 21:20:11 +0100
> > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> >
> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >> ---
> >> Documentation/serial/driver | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/Documentation/serial/driver
> >> b/Documentation/serial/driver index 77ba0af..0a25a91 100644
> >> --- a/Documentation/serial/driver
> >> +++ b/Documentation/serial/driver
> >> @@ -101,7 +101,7 @@ hardware.
> >> Returns the current state of modem control inputs. The
> >> state of the outputs should not be returned, since the core keeps
> >> track of their state. The state information should
> >> include:
> >> - - TIOCM_DCD state of DCD signal
> >> + - TIOCM_CAR state of DCD signal
> >> - TIOCM_CTS state of CTS signal
> >> - TIOCM_DSR state of DSR signal
> >> - TIOCM_RI state of RI signal
> >
> > Acked-by: Alan Cox <alan@linux.intel.com>
> >
> > but please fix the Subject line to be less confusing - it sounds
> > like it changes the define not the docs...
>
>
> (sorry for the delayed reply)
>
> I thought that DCD meant Data Carrier Detect. Is that old? Has it
> changed to just Carrier?
TIOCM_ are the kernel names. The documentation says we use TIOCM_DCD -
only we don't - the #define is TIOCM_CAR
So its a fix.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-05 0:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-02 20:20 [PATCH] serial/documentation: fix name of DCD cpp symbol Uwe Kleine-König
2011-12-02 23:42 ` Alan Cox
2012-01-04 23:13 ` Randy Dunlap
2012-01-04 22:24 ` Greg KH
2012-01-05 0:37 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox