* gpio_keys_polled.c and DT
@ 2012-06-19 15:02 Roland Stigge
2012-06-21 8:53 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Roland Stigge @ 2012-06-19 15:02 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: dgdunix, linux-input, linux-kernel
Hi,
as far as I can see, gpio_keys_polled.c currently doesn't support DT
initialization. Is there a plan in this regard?
Rather than duplicating the respective code from gpio_keys.c, maybe
gpio_keys.c could be changed to support a polled mode also? This way,
gpio_keys_polled.c could be removed.
I could try to do either of those.
Or am I missing sth. here?
Thanks in advance,
Roland
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: gpio_keys_polled.c and DT
2012-06-19 15:02 gpio_keys_polled.c and DT Roland Stigge
@ 2012-06-21 8:53 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2012-06-21 8:53 UTC (permalink / raw)
To: Roland Stigge; +Cc: dgdunix, linux-input, linux-kernel
Hi Roland,
On Tue, Jun 19, 2012 at 05:02:03PM +0200, Roland Stigge wrote:
> Hi,
>
> as far as I can see, gpio_keys_polled.c currently doesn't support DT
> initialization. Is there a plan in this regard?
>
> Rather than duplicating the respective code from gpio_keys.c, maybe
> gpio_keys.c could be changed to support a polled mode also? This way,
> gpio_keys_polled.c could be removed.
We had several attempts at gpio_keys and adding a polled mode and we
ended up with the driver getting too complex and having unwanted
dependencies. At the moment I believe that the split between gpio_keys.c
and gpio_keys_polled.c is justified even it it may lead to certain code
duplication.
However, if DT bindings are really the same we could split them off into
a separate library module used by both drivers.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-21 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-19 15:02 gpio_keys_polled.c and DT Roland Stigge
2012-06-21 8:53 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox