* [PATCH] input: Export matrix_keypad_parse_of_params()
@ 2013-04-15 12:06 Michal Marek
2013-04-15 16:07 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: Michal Marek @ 2013-04-15 12:06 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input; +Cc: Randy Dunlap, Simon Glass, linux-kernel
Couple of input drivers depend on this symbol:
ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/tca8418_keypad.ko] undefined!
ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/cros_ec_keyb.ko] undefined!
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>
---
drivers/input/matrix-keymap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/matrix-keymap.c b/drivers/input/matrix-keymap.c
index 619b382..08b61f5 100644
--- a/drivers/input/matrix-keymap.c
+++ b/drivers/input/matrix-keymap.c
@@ -68,6 +68,7 @@ int matrix_keypad_parse_of_params(struct device *dev,
return 0;
}
+EXPORT_SYMBOL_GPL(matrix_keypad_parse_of_params);
static int matrix_keypad_parse_of_keymap(const char *propname,
unsigned int rows, unsigned int cols,
--
1.8.2.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] input: Export matrix_keypad_parse_of_params()
2013-04-15 12:06 Michal Marek
@ 2013-04-15 16:07 ` Dmitry Torokhov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2013-04-15 16:07 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-input, Randy Dunlap, Simon Glass, linux-kernel
Hi Michal,
On Mon, Apr 15, 2013 at 02:06:48PM +0200, Michal Marek wrote:
> Couple of input drivers depend on this symbol:
>
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/tca8418_keypad.ko] undefined!
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/cros_ec_keyb.ko] undefined!
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Michal Marek <mmarek@suse.cz>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This is coming through some other tree though so you 'll have to track
it down.
Thanks.
> ---
> drivers/input/matrix-keymap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/matrix-keymap.c b/drivers/input/matrix-keymap.c
> index 619b382..08b61f5 100644
> --- a/drivers/input/matrix-keymap.c
> +++ b/drivers/input/matrix-keymap.c
> @@ -68,6 +68,7 @@ int matrix_keypad_parse_of_params(struct device *dev,
>
> return 0;
> }
> +EXPORT_SYMBOL_GPL(matrix_keypad_parse_of_params);
>
> static int matrix_keypad_parse_of_keymap(const char *propname,
> unsigned int rows, unsigned int cols,
> --
> 1.8.2.1
>
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] input: Export matrix_keypad_parse_of_params()
@ 2013-04-16 8:50 Michal Marek
2013-04-17 17:54 ` Randy Dunlap
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Michal Marek @ 2013-04-16 8:50 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: Randy Dunlap, Dmitry Torokhov, Simon Glass, linux-kernel
Couple of input drivers depend on this symbol:
ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/tca8418_keypad.ko] undefined!
ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/cros_ec_keyb.ko] undefined!
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>
---
drivers/input/matrix-keymap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/matrix-keymap.c b/drivers/input/matrix-keymap.c
index 619b382..08b61f5 100644
--- a/drivers/input/matrix-keymap.c
+++ b/drivers/input/matrix-keymap.c
@@ -68,6 +68,7 @@ int matrix_keypad_parse_of_params(struct device *dev,
return 0;
}
+EXPORT_SYMBOL_GPL(matrix_keypad_parse_of_params);
static int matrix_keypad_parse_of_keymap(const char *propname,
unsigned int rows, unsigned int cols,
--
1.8.2.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] input: Export matrix_keypad_parse_of_params()
2013-04-16 8:50 [PATCH] input: Export matrix_keypad_parse_of_params() Michal Marek
@ 2013-04-17 17:54 ` Randy Dunlap
2013-04-17 18:11 ` Simon Glass
2013-04-18 22:31 ` Samuel Ortiz
2 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2013-04-17 17:54 UTC (permalink / raw)
To: Michal Marek; +Cc: Samuel Ortiz, Dmitry Torokhov, Simon Glass, linux-kernel
On 04/16/13 01:50, Michal Marek wrote:
> Couple of input drivers depend on this symbol:
>
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/tca8418_keypad.ko] undefined!
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/cros_ec_keyb.ko] undefined!
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Michal Marek <mmarek@suse.cz>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/input/matrix-keymap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/matrix-keymap.c b/drivers/input/matrix-keymap.c
> index 619b382..08b61f5 100644
> --- a/drivers/input/matrix-keymap.c
> +++ b/drivers/input/matrix-keymap.c
> @@ -68,6 +68,7 @@ int matrix_keypad_parse_of_params(struct device *dev,
>
> return 0;
> }
> +EXPORT_SYMBOL_GPL(matrix_keypad_parse_of_params);
>
> static int matrix_keypad_parse_of_keymap(const char *propname,
> unsigned int rows, unsigned int cols,
>
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] input: Export matrix_keypad_parse_of_params()
2013-04-16 8:50 [PATCH] input: Export matrix_keypad_parse_of_params() Michal Marek
2013-04-17 17:54 ` Randy Dunlap
@ 2013-04-17 18:11 ` Simon Glass
2013-04-18 22:31 ` Samuel Ortiz
2 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2013-04-17 18:11 UTC (permalink / raw)
To: Michal Marek; +Cc: Samuel Ortiz, Randy Dunlap, Dmitry Torokhov, lk
On Tue, Apr 16, 2013 at 1:50 AM, Michal Marek <mmarek@suse.cz> wrote:
> Couple of input drivers depend on this symbol:
>
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/tca8418_keypad.ko] undefined!
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/cros_ec_keyb.ko] undefined!
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Michal Marek <mmarek@suse.cz>
Acked-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] input: Export matrix_keypad_parse_of_params()
2013-04-16 8:50 [PATCH] input: Export matrix_keypad_parse_of_params() Michal Marek
2013-04-17 17:54 ` Randy Dunlap
2013-04-17 18:11 ` Simon Glass
@ 2013-04-18 22:31 ` Samuel Ortiz
2 siblings, 0 replies; 6+ messages in thread
From: Samuel Ortiz @ 2013-04-18 22:31 UTC (permalink / raw)
To: Michal Marek; +Cc: Randy Dunlap, Dmitry Torokhov, Simon Glass, linux-kernel
Hi Marek,
On Tue, Apr 16, 2013 at 10:50:54AM +0200, Michal Marek wrote:
> Couple of input drivers depend on this symbol:
>
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/tca8418_keypad.ko] undefined!
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/cros_ec_keyb.ko] undefined!
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Michal Marek <mmarek@suse.cz>
> ---
> drivers/input/matrix-keymap.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-18 22:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-16 8:50 [PATCH] input: Export matrix_keypad_parse_of_params() Michal Marek
2013-04-17 17:54 ` Randy Dunlap
2013-04-17 18:11 ` Simon Glass
2013-04-18 22:31 ` Samuel Ortiz
-- strict thread matches above, loose matches on Subject: below --
2013-04-15 12:06 Michal Marek
2013-04-15 16:07 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox