[PATCH] ASoC: samsung: Add MODULE_DEVICE_TABLE for Snow

[PATCH] ASoC: samsung: Add MODULE_DEVICE_TABLE for Snow

[Andreas Färber]

This enables the snd_soc_snow module to be auto-loaded.

Fixes: da5993df2374 ("ASoC: samsung: Add sound card driver for Snow board")
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 Tested using patches for Spring, but should apply to Snow/Peach-pi equally.
 Rebased onto sound.git for-next branch.

 sound/soc/samsung/snow.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/samsung/snow.c b/sound/soc/samsung/snow.c
index 0acf5d0eed53..72118a77dd5b 100644
--- a/sound/soc/samsung/snow.c
+++ b/sound/soc/samsung/snow.c
@@ -110,6 +110,7 @@ static const struct of_device_id snow_of_match[] = {
 	{ .compatible = "google,snow-audio-max98095", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, snow_of_match);
 
 static struct platform_driver snow_driver = {
 	.driver = {
-- 
2.1.2

Re: [PATCH] ASoC: samsung: Add MODULE_DEVICE_TABLE for Snow

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

On Wed, Nov 05, 2014 at 05:44:52PM +0100, Andreas Färber wrote:
> This enables the snd_soc_snow module to be auto-loaded.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH] ASoC: samsung: Add MODULE_DEVICE_TABLE for Snow

[Andreas Färber]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

Am 05.11.2014 um 18:09 schrieb Mark Brown:
> On Wed, Nov 05, 2014 at 05:44:52PM +0100, Andreas Färber wrote:
>> This enables the snd_soc_snow module to be auto-loaded.
> 
> Applied, thanks.

Thanks. I notice you dropped my Fixes: line that SubmittingPatches asks
for. When do I need it and when should I leave it out? I thought it
tells GregKH more precisely which stable branches are affected for
backports than just a CC.

Regards,
Andreas

-- 
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] ASoC: samsung: Add MODULE_DEVICE_TABLE for Snow

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

On Wed, Nov 05, 2014 at 07:11:06PM +0100, Andreas Färber wrote:
> Am 05.11.2014 um 18:09 schrieb Mark Brown:
> > On Wed, Nov 05, 2014 at 05:44:52PM +0100, Andreas Färber wrote:
> >> This enables the snd_soc_snow module to be auto-loaded.

> > Applied, thanks.

> Thanks. I notice you dropped my Fixes: line that SubmittingPatches asks
> for. When do I need it and when should I leave it out? I thought it
> tells GregKH more precisely which stable branches are affected for
> backports than just a CC.

It's not really adding anything if it's just identifying the patch that
created the file in the first place and what actually happened here is
that I applied it without the tag then later went back and decided to
add a stable Cc since it was probably worth that.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]