* [PATCH] net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI not selected
@ 2015-09-24 10:16 Sudip Mukherjee
2015-09-25 18:03 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2015-09-24 10:16 UTC (permalink / raw)
To: David S. Miller, Hans-Christian Egtvedt
Cc: linux-kernel, netdev, Andrew Morton, Sudip Mukherjee
The builds of allmodconfig of avr32 is failing with:
drivers/net/ethernet/via/via-rhine.c:1098:2: error: implicit declaration
of function 'pci_iomap' [-Werror=implicit-function-declaration]
drivers/net/ethernet/via/via-rhine.c:1119:2: error: implicit declaration
of function 'pci_iounmap' [-Werror=implicit-function-declaration]
The generic empty pci_iomap and pci_iounmap is used only if CONFIG_PCI
is not defined and CONFIG_GENERIC_PCI_IOMAP is defined.
Add GENERIC_PCI_IOMAP in the dependency list for VIA_RHINE as we are
getting build failure when CONFIG_PCI and CONFIG_GENERIC_PCI_IOMAP both
are not defined.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
Failed build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/81127188
An exactly similar patch has been posted earlier and relevant discussion
is at:
https://patchwork.ozlabs.org/patch/498722/
I posted a patch to include empty pci_iomap, pci_iounmap in avr32. That
discussion is at:
https://lkml.org/lkml/2015/9/19/100
drivers/net/ethernet/via/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/via/Kconfig b/drivers/net/ethernet/via/Kconfig
index 2f1264b..17831e5 100644
--- a/drivers/net/ethernet/via/Kconfig
+++ b/drivers/net/ethernet/via/Kconfig
@@ -17,7 +17,7 @@ if NET_VENDOR_VIA
config VIA_RHINE
tristate "VIA Rhine support"
- depends on (PCI || OF_IRQ)
+ depends on (PCI || (OF_IRQ && GENERIC_PCI_IOMAP))
depends on HAS_DMA
select CRC32
select MII
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI not selected
2015-09-24 10:16 [PATCH] net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI not selected Sudip Mukherjee
@ 2015-09-25 18:03 ` Sergei Shtylyov
2015-09-25 19:37 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2015-09-25 18:03 UTC (permalink / raw)
To: Sudip Mukherjee, David S. Miller, Hans-Christian Egtvedt
Cc: linux-kernel, netdev, Andrew Morton
Hello.
On 9/24/2015 1:16 PM, Sudip Mukherjee wrote:
> The builds of allmodconfig of avr32 is failing with:
>
> drivers/net/ethernet/via/via-rhine.c:1098:2: error: implicit declaration
> of function 'pci_iomap' [-Werror=implicit-function-declaration]
> drivers/net/ethernet/via/via-rhine.c:1119:2: error: implicit declaration
> of function 'pci_iounmap' [-Werror=implicit-function-declaration]
>
> The generic empty pci_iomap and pci_iounmap is used only if CONFIG_PCI
> is not defined and CONFIG_GENERIC_PCI_IOMAP is defined.
>
> Add GENERIC_PCI_IOMAP in the dependency list for VIA_RHINE as we are
> getting build failure when CONFIG_PCI and CONFIG_GENERIC_PCI_IOMAP both
> are not defined.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>
> Failed build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/81127188
>
> An exactly similar patch has been posted earlier and relevant discussion
> is at:
> https://patchwork.ozlabs.org/patch/498722/
>
> I posted a patch to include empty pci_iomap, pci_iounmap in avr32. That
> discussion is at:
> https://lkml.org/lkml/2015/9/19/100
>
> drivers/net/ethernet/via/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/via/Kconfig b/drivers/net/ethernet/via/Kconfig
> index 2f1264b..17831e5 100644
> --- a/drivers/net/ethernet/via/Kconfig
> +++ b/drivers/net/ethernet/via/Kconfig
> @@ -17,7 +17,7 @@ if NET_VENDOR_VIA
>
> config VIA_RHINE
> tristate "VIA Rhine support"
> - depends on (PCI || OF_IRQ)
> + depends on (PCI || (OF_IRQ && GENERIC_PCI_IOMAP))
Could you remove outer braces, while at it?
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI not selected
2015-09-25 18:03 ` Sergei Shtylyov
@ 2015-09-25 19:37 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2015-09-25 19:37 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: sudipm.mukherjee, egtvedt, linux-kernel, netdev, akpm
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 25 Sep 2015 21:03:52 +0300
> Hello.
>
> On 9/24/2015 1:16 PM, Sudip Mukherjee wrote:
>
>> The builds of allmodconfig of avr32 is failing with:
>>
>> drivers/net/ethernet/via/via-rhine.c:1098:2: error: implicit
>> declaration
>> of function 'pci_iomap' [-Werror=implicit-function-declaration]
>> drivers/net/ethernet/via/via-rhine.c:1119:2: error: implicit
>> declaration
>> of function 'pci_iounmap' [-Werror=implicit-function-declaration]
>>
>> The generic empty pci_iomap and pci_iounmap is used only if CONFIG_PCI
>> is not defined and CONFIG_GENERIC_PCI_IOMAP is defined.
>>
>> Add GENERIC_PCI_IOMAP in the dependency list for VIA_RHINE as we are
>> getting build failure when CONFIG_PCI and CONFIG_GENERIC_PCI_IOMAP
>> both
>> are not defined.
>>
>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
...
>> @@ -17,7 +17,7 @@ if NET_VENDOR_VIA
>>
>> config VIA_RHINE
>> tristate "VIA Rhine support"
>> - depends on (PCI || OF_IRQ)
>> + depends on (PCI || (OF_IRQ && GENERIC_PCI_IOMAP))
>
> Could you remove outer braces, while at it?
I took care of this while applying this patch, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-25 19:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-24 10:16 [PATCH] net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI not selected Sudip Mukherjee
2015-09-25 18:03 ` Sergei Shtylyov
2015-09-25 19:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox