* [PATCH] sign-file: fix the perl warning message when extracting ASN.1
@ 2012-11-20 10:46 Lee, Chun-Yi
0 siblings, 0 replies; 3+ messages in thread
From: Lee, Chun-Yi @ 2012-11-20 10:46 UTC (permalink / raw)
To: dhowells; +Cc: linux-kernel, jlee
There have the following warning message when running modules install for sign ko files:
# make modules_install
...
INSTALL drivers/input/touchscreen/pcap_ts.ko
Found = in conditional, should be == at scripts/sign-file line 164.
Found = in conditional, should be == at scripts/sign-file line 161.
Found = in conditional, should be == at scripts/sign-file line 159.
This patch change replace '=' by '==' in elsif conditions for avoid the above warning messages.
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
scripts/sign-file | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/sign-file b/scripts/sign-file
index 87ca59d..974a20b 100755
--- a/scripts/sign-file
+++ b/scripts/sign-file
@@ -156,12 +156,12 @@ sub asn1_extract($$@)
if ($l == 0x1) {
$len = unpack("C", substr(${$cursor->[2]}, $cursor->[0], 1));
- } elsif ($l = 0x2) {
+ } elsif ($l == 0x2) {
$len = unpack("n", substr(${$cursor->[2]}, $cursor->[0], 2));
- } elsif ($l = 0x3) {
+ } elsif ($l == 0x3) {
$len = unpack("C", substr(${$cursor->[2]}, $cursor->[0], 1)) << 16;
$len = unpack("n", substr(${$cursor->[2]}, $cursor->[0] + 1, 2));
- } elsif ($l = 0x4) {
+ } elsif ($l == 0x4) {
$len = unpack("N", substr(${$cursor->[2]}, $cursor->[0], 4));
} else {
die $x509, ": ", $cursor->[0], ": ASN.1 element too long (", $l, ")\n";
--
1.6.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] sign-file: fix the perl warning message when extracting ASN.1
@ 2012-11-21 11:26 David Howells
2012-11-21 11:40 ` David Howells
0 siblings, 1 reply; 3+ messages in thread
From: David Howells @ 2012-11-21 11:26 UTC (permalink / raw)
To: torvalds, rusty; +Cc: Chun-Yi Lee, linux-kernel
There have the following warning message when running modules install for sign ko files:
# make modules_install
...
INSTALL drivers/input/touchscreen/pcap_ts.ko
Found = in conditional, should be == at scripts/sign-file line 164.
Found = in conditional, should be == at scripts/sign-file line 161.
Found = in conditional, should be == at scripts/sign-file line 159.
This patch change replace '=' by '==' in elsif conditions for avoid the above warning messages.
Signed-off-by: Chun-Yi Lee <jlee@suse.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---
scripts/sign-file | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/sign-file b/scripts/sign-file
index 87ca59d..974a20b 100755
--- a/scripts/sign-file
+++ b/scripts/sign-file
@@ -156,12 +156,12 @@ sub asn1_extract($$@)
if ($l == 0x1) {
$len = unpack("C", substr(${$cursor->[2]}, $cursor->[0], 1));
- } elsif ($l = 0x2) {
+ } elsif ($l == 0x2) {
$len = unpack("n", substr(${$cursor->[2]}, $cursor->[0], 2));
- } elsif ($l = 0x3) {
+ } elsif ($l == 0x3) {
$len = unpack("C", substr(${$cursor->[2]}, $cursor->[0], 1)) << 16;
$len = unpack("n", substr(${$cursor->[2]}, $cursor->[0] + 1, 2));
- } elsif ($l = 0x4) {
+ } elsif ($l == 0x4) {
$len = unpack("N", substr(${$cursor->[2]}, $cursor->[0], 4));
} else {
die $x509, ": ", $cursor->[0], ": ASN.1 element too long (", $l, ")\n";
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sign-file: fix the perl warning message when extracting ASN.1
2012-11-21 11:26 [PATCH] sign-file: fix the perl warning message when extracting ASN.1 David Howells
@ 2012-11-21 11:40 ` David Howells
0 siblings, 0 replies; 3+ messages in thread
From: David Howells @ 2012-11-21 11:40 UTC (permalink / raw)
To: torvalds, rusty; +Cc: dhowells, Chun-Yi Lee, linux-kernel
David Howells <dhowells@redhat.com> wrote:
> There have the following warning message when running modules install for sign ko files:
>
> # make modules_install
> ...
> INSTALL drivers/input/touchscreen/pcap_ts.ko
> Found = in conditional, should be == at scripts/sign-file line 164.
> Found = in conditional, should be == at scripts/sign-file line 161.
> Found = in conditional, should be == at scripts/sign-file line 159.
>
> This patch change replace '=' by '==' in elsif conditions for avoid the above warning messages.
>
> Signed-off-by: Chun-Yi Lee <jlee@suse.com>
> Signed-off-by: David Howells <dhowells@redhat.com>
Hmmm... It seems that stgit-0.16 no longer puts authorship information into
the mail message. This was actually authored by Chun-Yi Lee, not myself.
David
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-21 12:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-21 11:26 [PATCH] sign-file: fix the perl warning message when extracting ASN.1 David Howells
2012-11-21 11:40 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2012-11-20 10:46 Lee, Chun-Yi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox