[PATCH] ALSA: usb-audio: Convert comma to semicolon

[PATCH] ALSA: usb-audio: Convert comma to semicolon

[Chen Ni]

Replace comma between expressions with semicolons.

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 sound/usb/mixer_quirks.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
index 0769ecd91144..a0ffe8b559dc 100644
--- a/sound/usb/mixer_quirks.c
+++ b/sound/usb/mixer_quirks.c
@@ -762,9 +762,9 @@ static int snd_dualsense_jack_create(struct usb_mixer_interface *mixer,
 
 	mei->ih.event = snd_dualsense_ih_event;
 	mei->ih.match = snd_dualsense_ih_match;
-	mei->ih.connect = snd_dualsense_ih_connect,
-	mei->ih.disconnect = snd_dualsense_ih_disconnect,
-	mei->ih.start = snd_dualsense_ih_start,
+	mei->ih.connect = snd_dualsense_ih_connect;
+	mei->ih.disconnect = snd_dualsense_ih_disconnect;
+	mei->ih.start = snd_dualsense_ih_start;
 	mei->ih.name = name;
 	mei->ih.id_table = mei->id_table;
 
-- 
2.25.1

Re: [PATCH] ALSA: usb-audio: Convert comma to semicolon

[Cristian Ciocaltea]

On 6/12/25 9:02 AM, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  sound/usb/mixer_quirks.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
> index 0769ecd91144..a0ffe8b559dc 100644
> --- a/sound/usb/mixer_quirks.c
> +++ b/sound/usb/mixer_quirks.c
> @@ -762,9 +762,9 @@ static int snd_dualsense_jack_create(struct usb_mixer_interface *mixer,
>  
>  	mei->ih.event = snd_dualsense_ih_event;
>  	mei->ih.match = snd_dualsense_ih_match;
> -	mei->ih.connect = snd_dualsense_ih_connect,
> -	mei->ih.disconnect = snd_dualsense_ih_disconnect,
> -	mei->ih.start = snd_dualsense_ih_start,
> +	mei->ih.connect = snd_dualsense_ih_connect;
> +	mei->ih.disconnect = snd_dualsense_ih_disconnect;
> +	mei->ih.start = snd_dualsense_ih_start;
>  	mei->ih.name = name;
>  	mei->ih.id_table = mei->id_table;


Thanks for catching this!

Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>

Re: [PATCH] ALSA: usb-audio: Convert comma to semicolon

[Takashi Iwai]

On Thu, 12 Jun 2025 08:02:28 +0200,
Chen Ni wrote:
> 
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Thanks, applied now.

At the next time, though, it'd be appreciated if you can put the
proper Fixes tag.


Takashi

Re: [PATCH] ALSA: usb-audio: Convert comma to semicolon

[Cristian Ciocaltea]

On 6/12/25 9:52 AM, Takashi Iwai wrote:
> On Thu, 12 Jun 2025 08:02:28 +0200,
> Chen Ni wrote:
>>
>> Replace comma between expressions with semicolons.
>>
>> Using a ',' in place of a ';' can have unintended side effects.
>> Although that is not the case here, it is seems best to use ';'
>> unless ',' is intended.
>>
>> Found by inspection.
>> No functional change intended.
>> Compile tested only.
>>
>> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> 
> Thanks, applied now.
> 
> At the next time, though, it'd be appreciated if you can put the
> proper Fixes tag.

Considering this is not really a functional change, I think a 
Fixes tag would trigger an unnecessary backport, wouldn't it?

Regards,
Cristian

Re: [PATCH] ALSA: usb-audio: Convert comma to semicolon

[Takashi Iwai]

On Thu, 12 Jun 2025 09:22:36 +0200,
Cristian Ciocaltea wrote:
> 
> On 6/12/25 9:52 AM, Takashi Iwai wrote:
> > On Thu, 12 Jun 2025 08:02:28 +0200,
> > Chen Ni wrote:
> >>
> >> Replace comma between expressions with semicolons.
> >>
> >> Using a ',' in place of a ';' can have unintended side effects.
> >> Although that is not the case here, it is seems best to use ';'
> >> unless ',' is intended.
> >>
> >> Found by inspection.
> >> No functional change intended.
> >> Compile tested only.
> >>
> >> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> > 
> > Thanks, applied now.
> > 
> > At the next time, though, it'd be appreciated if you can put the
> > proper Fixes tag.
> 
> Considering this is not really a functional change, I think a 
> Fixes tag would trigger an unnecessary backport, wouldn't it?

If it were in the old released kernels, I wouldn't be bothered,
either.  But this is still in staging for the next, and having Fixes
tag will help to track if someone tries to backport patches.
Otherwise the code differs and may give conflicts in further
backports.


thanks,

Takashi

Re: [PATCH] ALSA: usb-audio: Convert comma to semicolon

[Cristian Ciocaltea]

On 6/12/25 10:30 AM, Takashi Iwai wrote:
> On Thu, 12 Jun 2025 09:22:36 +0200,
> Cristian Ciocaltea wrote:
>>
>> On 6/12/25 9:52 AM, Takashi Iwai wrote:
>>> On Thu, 12 Jun 2025 08:02:28 +0200,
>>> Chen Ni wrote:
>>>>
>>>> Replace comma between expressions with semicolons.
>>>>
>>>> Using a ',' in place of a ';' can have unintended side effects.
>>>> Although that is not the case here, it is seems best to use ';'
>>>> unless ',' is intended.
>>>>
>>>> Found by inspection.
>>>> No functional change intended.
>>>> Compile tested only.
>>>>
>>>> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
>>>
>>> Thanks, applied now.
>>>
>>> At the next time, though, it'd be appreciated if you can put the
>>> proper Fixes tag.
>>
>> Considering this is not really a functional change, I think a 
>> Fixes tag would trigger an unnecessary backport, wouldn't it?
> 
> If it were in the old released kernels, I wouldn't be bothered,
> either.  But this is still in staging for the next, and having Fixes
> tag will help to track if someone tries to backport patches.
> Otherwise the code differs and may give conflicts in further
> backports.

Oh, indeed, thanks for pointing this out!

Regards,
Cristian