* [PATCH] selftests: add missing ')' in lib.mk
@ 2022-08-09 13:20 Guillaume Tucker
2022-08-09 16:36 ` Nathan Chancellor
0 siblings, 1 reply; 4+ messages in thread
From: Guillaume Tucker @ 2022-08-09 13:20 UTC (permalink / raw)
To: Shuah Khan, Nathan Chancellor, Nick Desaulniers, Tom Rix,
Mark Brown
Cc: kernel, linux-kernel, linux-kselftest, llvm
Add missing closing ')' in lib.mk in a call to $error(). This only
affects LLVM / Clang builds.
Fixes: 795285ef2425 ("selftests: Fix clang cross compilation")
Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
---
tools/testing/selftests/lib.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index 947fc72413e9..a87f60873e5b 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -20,7 +20,7 @@ CLANG_TARGET_FLAGS := $(CLANG_TARGET_FLAGS_$(ARCH))
ifeq ($(CROSS_COMPILE),)
ifeq ($(CLANG_TARGET_FLAGS),)
-$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk
+$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk)
else
CLANG_FLAGS += --target=$(CLANG_TARGET_FLAGS)
endif # CLANG_TARGET_FLAGS
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] selftests: add missing ')' in lib.mk
2022-08-09 13:20 [PATCH] selftests: add missing ')' in lib.mk Guillaume Tucker
@ 2022-08-09 16:36 ` Nathan Chancellor
2023-02-03 15:40 ` Guillaume Tucker
0 siblings, 1 reply; 4+ messages in thread
From: Nathan Chancellor @ 2022-08-09 16:36 UTC (permalink / raw)
To: Guillaume Tucker
Cc: Shuah Khan, Nick Desaulniers, Tom Rix, Mark Brown, kernel,
linux-kernel, linux-kselftest, llvm
On Tue, Aug 09, 2022 at 03:20:46PM +0200, Guillaume Tucker wrote:
> Add missing closing ')' in lib.mk in a call to $error(). This only
> affects LLVM / Clang builds.
>
> Fixes: 795285ef2425 ("selftests: Fix clang cross compilation")
> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> tools/testing/selftests/lib.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 947fc72413e9..a87f60873e5b 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -20,7 +20,7 @@ CLANG_TARGET_FLAGS := $(CLANG_TARGET_FLAGS_$(ARCH))
>
> ifeq ($(CROSS_COMPILE),)
> ifeq ($(CLANG_TARGET_FLAGS),)
> -$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk
> +$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk)
> else
> CLANG_FLAGS += --target=$(CLANG_TARGET_FLAGS)
> endif # CLANG_TARGET_FLAGS
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selftests: add missing ')' in lib.mk
2022-08-09 16:36 ` Nathan Chancellor
@ 2023-02-03 15:40 ` Guillaume Tucker
2023-02-03 16:14 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Guillaume Tucker @ 2023-02-03 15:40 UTC (permalink / raw)
To: Nathan Chancellor, Shuah Khan
Cc: Nick Desaulniers, Tom Rix, Mark Brown, kernel, linux-kernel,
linux-kselftest, llvm
On 09/08/2022 18:36, Nathan Chancellor wrote:
> On Tue, Aug 09, 2022 at 03:20:46PM +0200, Guillaume Tucker wrote:
>> Add missing closing ')' in lib.mk in a call to $error(). This only
>> affects LLVM / Clang builds.
>>
>> Fixes: 795285ef2425 ("selftests: Fix clang cross compilation")
>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Ha, I see Mark just came up with the same fix many months later :)
Shame this wasn't applied back then, for some reason...
Guillaume
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selftests: add missing ')' in lib.mk
2023-02-03 15:40 ` Guillaume Tucker
@ 2023-02-03 16:14 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2023-02-03 16:14 UTC (permalink / raw)
To: Guillaume Tucker, Nathan Chancellor, Shuah Khan
Cc: Nick Desaulniers, Tom Rix, Mark Brown, kernel, linux-kernel,
linux-kselftest, llvm, Shuah Khan
On 2/3/23 08:40, Guillaume Tucker wrote:
> On 09/08/2022 18:36, Nathan Chancellor wrote:
>> On Tue, Aug 09, 2022 at 03:20:46PM +0200, Guillaume Tucker wrote:
>>> Add missing closing ')' in lib.mk in a call to $error(). This only
>>> affects LLVM / Clang builds.
>>>
>>> Fixes: 795285ef2425 ("selftests: Fix clang cross compilation")
>>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
>>
>> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> Ha, I see Mark just came up with the same fix many months later :)
> Shame this wasn't applied back then, for some reason...
>
It might have gotten lost in my Inbox (looking at the dates - must have
been while I was away on vacation). Sorry about that.
It is fixed now.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-03 16:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-09 13:20 [PATCH] selftests: add missing ')' in lib.mk Guillaume Tucker
2022-08-09 16:36 ` Nathan Chancellor
2023-02-03 15:40 ` Guillaume Tucker
2023-02-03 16:14 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox