Re: [PATCH] f2fs: make f2fs_read_inline_data() more readable

Re: [PATCH] f2fs: make f2fs_read_inline_data() more readable

[Chao Yu]

On 2022/5/18 10:33, Chao Liu wrote:
> In f2fs_read_inline_data(), it is confused with checking of
> inline_data flag, as we checked it before calling. So this
> patch add some comments for f2fs_has_inline_data().
> 
> Signed-off-by: Chao Liu

It looks email address is missing, but it shows after I can apply this
patch to my local git repo...

Could you please check your email client configuration?

Thanks,

> ---
> fs/f2fs/f2fs.h | 4 ++++
> 1 file changed, 4 insertions(+)
> 
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index f579e2ed0f14..5071f6636e41 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -3167,6 +3167,10 @@ static inline int inline_xattr_size(struct inode *inode)
> return 0;
> }
> 
> +/*
> + * Notice: check inline_data flag without inode page lock is unsafe.
> + * It could change at any time by f2fs_convert_inline_page().
> + */
> static inline int f2fs_has_inline_data(struct inode *inode)
> {
> return is_inode_flag_set(inode, FI_INLINE_DATA);
> -- 
> 2.25.1
> 

Re: [PATCH] f2fs: make f2fs_read_inline_data() more readable

[Chao Liu]

On Wed, May 18, 2022 at 11:23 PM Chao Yu <chao@kernel.org> wrote:
>
> On 2022/5/18 10:33, Chao Liu wrote:
> > In f2fs_read_inline_data(), it is confused with checking of
> > inline_data flag, as we checked it before calling. So this
> > patch add some comments for f2fs_has_inline_data().
> >
> > Signed-off-by: Chao Liu
>
> It looks email address is missing, but it shows after I can apply this
> patch to my local git repo...
>
> Could you please check your email client configuration?

Oh, sorry, this may be caused by my SMTP server, I will try to
resend it later via this email address.

>
> Thanks,
>
> > ---
> > fs/f2fs/f2fs.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> > index f579e2ed0f14..5071f6636e41 100644
> > --- a/fs/f2fs/f2fs.h
> > +++ b/fs/f2fs/f2fs.h
> > @@ -3167,6 +3167,10 @@ static inline int inline_xattr_size(struct inode *inode)
> > return 0;
> > }
> >
> > +/*
> > + * Notice: check inline_data flag without inode page lock is unsafe.
> > + * It could change at any time by f2fs_convert_inline_page().
> > + */
> > static inline int f2fs_has_inline_data(struct inode *inode)
> > {
> > return is_inode_flag_set(inode, FI_INLINE_DATA);
> > --
> > 2.25.1
> >