* Re: [PATCH] f2fs: make f2fs_read_inline_data() more readable [not found] <20220518023123.2455827-1-liuchao@coolpad.com> @ 2022-05-18 15:23 ` Chao Yu 2022-05-19 6:09 ` Chao Liu 0 siblings, 1 reply; 2+ messages in thread From: Chao Yu @ 2022-05-18 15:23 UTC (permalink / raw) To: Chao Liu, Jaegeuk Kim Cc: linux-f2fs-devel, linux-kernel, Yue Hu, Wayne Zhang, Chao Liu On 2022/5/18 10:33, Chao Liu wrote: > In f2fs_read_inline_data(), it is confused with checking of > inline_data flag, as we checked it before calling. So this > patch add some comments for f2fs_has_inline_data(). > > Signed-off-by: Chao Liu It looks email address is missing, but it shows after I can apply this patch to my local git repo... Could you please check your email client configuration? Thanks, > --- > fs/f2fs/f2fs.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index f579e2ed0f14..5071f6636e41 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -3167,6 +3167,10 @@ static inline int inline_xattr_size(struct inode *inode) > return 0; > } > > +/* > + * Notice: check inline_data flag without inode page lock is unsafe. > + * It could change at any time by f2fs_convert_inline_page(). > + */ > static inline int f2fs_has_inline_data(struct inode *inode) > { > return is_inode_flag_set(inode, FI_INLINE_DATA); > -- > 2.25.1 > ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] f2fs: make f2fs_read_inline_data() more readable 2022-05-18 15:23 ` [PATCH] f2fs: make f2fs_read_inline_data() more readable Chao Yu @ 2022-05-19 6:09 ` Chao Liu 0 siblings, 0 replies; 2+ messages in thread From: Chao Liu @ 2022-05-19 6:09 UTC (permalink / raw) To: Chao Yu Cc: Chao Liu, Jaegeuk Kim, linux-f2fs-devel, linux-kernel, Yue Hu, Wayne Zhang On Wed, May 18, 2022 at 11:23 PM Chao Yu <chao@kernel.org> wrote: > > On 2022/5/18 10:33, Chao Liu wrote: > > In f2fs_read_inline_data(), it is confused with checking of > > inline_data flag, as we checked it before calling. So this > > patch add some comments for f2fs_has_inline_data(). > > > > Signed-off-by: Chao Liu > > It looks email address is missing, but it shows after I can apply this > patch to my local git repo... > > Could you please check your email client configuration? Oh, sorry, this may be caused by my SMTP server, I will try to resend it later via this email address. > > Thanks, > > > --- > > fs/f2fs/f2fs.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > > index f579e2ed0f14..5071f6636e41 100644 > > --- a/fs/f2fs/f2fs.h > > +++ b/fs/f2fs/f2fs.h > > @@ -3167,6 +3167,10 @@ static inline int inline_xattr_size(struct inode *inode) > > return 0; > > } > > > > +/* > > + * Notice: check inline_data flag without inode page lock is unsafe. > > + * It could change at any time by f2fs_convert_inline_page(). > > + */ > > static inline int f2fs_has_inline_data(struct inode *inode) > > { > > return is_inode_flag_set(inode, FI_INLINE_DATA); > > -- > > 2.25.1 > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-19 6:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220518023123.2455827-1-liuchao@coolpad.com>
2022-05-18 15:23 ` [PATCH] f2fs: make f2fs_read_inline_data() more readable Chao Yu
2022-05-19 6:09 ` Chao Liu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox