* [PATCH] drm/sched: Fix incorrect test description in drm_sched_basic_cases
@ 2026-08-21 8:47 oushixiong1025
2026-08-25 7:04 ` Philipp Stanner
0 siblings, 1 reply; 2+ messages in thread
From: oushixiong1025 @ 2026-08-21 8:47 UTC (permalink / raw)
To: Matthew Brost
Cc: Danilo Krummrich, Philipp Stanner, Christian König,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, dri-devel, linux-kernel, Shixiong Ou
From: Shixiong Ou <oushixiong@kylinos.cn>
The second test case in drm_sched_basic_cases[] has num_entities = 1
but its description claims "across multiple entities". Fix it to
accurately reflect that the dependency chain operates within a single
entity.
Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
---
drivers/gpu/drm/scheduler/tests/tests_basic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/tests/tests_basic.c b/drivers/gpu/drm/scheduler/tests/tests_basic.c
index da5c4952780f..34bbb2c27913 100644
--- a/drivers/gpu/drm/scheduler/tests/tests_basic.c
+++ b/drivers/gpu/drm/scheduler/tests/tests_basic.c
@@ -90,7 +90,7 @@ static const struct drm_sched_basic_params drm_sched_basic_cases[] = {
.num_entities = 1,
},
{
- .description = "A chain of dependent jobs across multiple entities",
+ .description = "A chain of dependent jobs in a single entity",
.queue_depth = 100,
.job_us = 1000,
.num_entities = 1,
--
2.25.1
No virus found
Checked by Hillstone Network AntiVirus
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/sched: Fix incorrect test description in drm_sched_basic_cases
2026-08-21 8:47 [PATCH] drm/sched: Fix incorrect test description in drm_sched_basic_cases oushixiong1025
@ 2026-08-25 7:04 ` Philipp Stanner
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Stanner @ 2026-08-25 7:04 UTC (permalink / raw)
To: oushixiong1025, Matthew Brost
Cc: Danilo Krummrich, Philipp Stanner, Christian König,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, dri-devel, linux-kernel, Shixiong Ou
+Cc Marco, Tvrtko
On Fri, 2026-08-21 at 16:47 +0800, oushixiong1025@163.com wrote:
> From: Shixiong Ou <oushixiong@kylinos.cn>
>
> The second test case in drm_sched_basic_cases[] has num_entities = 1
> but its description claims "across multiple entities". Fix it to
> accurately reflect that the dependency chain operates within a single
> entity.
>
> Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
Thx for the patch. Applied to drm-misc-next.
Tvrtko, added you for awareness. Maybe this indicates a gap in the test
coverage as you originally envisioned it?
P.
> ---
> drivers/gpu/drm/scheduler/tests/tests_basic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/scheduler/tests/tests_basic.c b/drivers/gpu/drm/scheduler/tests/tests_basic.c
> index da5c4952780f..34bbb2c27913 100644
> --- a/drivers/gpu/drm/scheduler/tests/tests_basic.c
> +++ b/drivers/gpu/drm/scheduler/tests/tests_basic.c
> @@ -90,7 +90,7 @@ static const struct drm_sched_basic_params drm_sched_basic_cases[] = {
> .num_entities = 1,
> },
> {
> - .description = "A chain of dependent jobs across multiple entities",
> + .description = "A chain of dependent jobs in a single entity",
> .queue_depth = 100,
> .job_us = 1000,
> .num_entities = 1,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-25 7:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-21 8:47 [PATCH] drm/sched: Fix incorrect test description in drm_sched_basic_cases oushixiong1025
2026-08-25 7:04 ` Philipp Stanner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox