From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Ravikiran G Thirumalai" <kiran@scalex86.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Ingo Molnar" <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
"Glauber de Oliveira Costa" <gcosta@redhat.com>,
"Andi Kleen" <ak@suse.de>,
shai@scalex86.org
Subject: Re: [patch 1/4] x86: vSMP: Fix is_vsmp_box()
Date: Thu, 20 Mar 2008 00:44:37 -0700 [thread overview]
Message-ID: <86802c440803200044g54617517k4530db76ebe2cabb@mail.gmail.com> (raw)
In-Reply-To: <20080320073902.GB9414@localdomain>
On Thu, Mar 20, 2008 at 12:39 AM, Ravikiran G Thirumalai
<kiran@scalex86.org> wrote:
> is_vsmp_box() currently does not work on vSMPowered systems, as pci cfg
> space is not read correctly -- This patch fixes it.
>
> Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
>
> Index: linux.git.trees/arch/x86/kernel/vsmp_64.c
> ===================================================================
> --- linux.git.trees.orig/arch/x86/kernel/vsmp_64.c 2008-03-19 13:30:35.116766719 -0700
> +++ linux.git.trees/arch/x86/kernel/vsmp_64.c 2008-03-19 13:39:20.074685590 -0700
> @@ -84,8 +84,10 @@ int is_vsmp_box(void)
> return vsmp;
>
> /* Check if we are running on a ScaleMP vSMP box */
> - if (read_pci_config(0, 0x1f, 0, PCI_VENDOR_ID) ==
> - (PCI_VENDOR_ID_SCALEMP || (PCI_DEVICE_ID_SCALEMP_VSMP_CTL << 16)))
> + if ((read_pci_config_16(0, 0x1f, 0, PCI_VENDOR_ID) ==
> + PCI_VENDOR_ID_SCALEMP) &&
> + (read_pci_config_16(0, 0x1f, 0, PCI_DEVICE_ID) ==
> + PCI_DEVICE_ID_SCALEMP_VSMP_CTL))
> vsmp = 1;
>
> return vsmp;
why read two times
or
(PCI_VENDOR_ID_SCALEMP || (PCI_DEVICE_ID_SCALEMP_VSMP_CTL << 16)))
should be
(PCI_VENDOR_ID_SCALEMP | (PCI_DEVICE_ID_SCALEMP_VSMP_CTL << 16)))
YH
next prev parent reply other threads:[~2008-03-20 7:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 7:37 [patch 0/4] x86: vSMP updates Ravikiran G Thirumalai
2008-03-20 7:39 ` [patch 1/4] x86: vSMP: Fix is_vsmp_box() Ravikiran G Thirumalai
2008-03-20 7:44 ` Yinghai Lu [this message]
2008-03-20 18:40 ` Ravikiran G Thirumalai
2008-03-21 9:11 ` Ingo Molnar
2008-03-21 9:17 ` Yinghai Lu
2008-03-21 17:59 ` Ravikiran G Thirumalai
2008-03-20 7:41 ` [patch 2/4] x86: Fix build breakage when PCI is define and PARAVIRT is not Ravikiran G Thirumalai
2008-03-21 4:30 ` Jeremy Fitzhardinge
2008-03-21 6:28 ` Yinghai Lu
2008-03-21 18:54 ` Ravikiran G Thirumalai
2008-03-22 2:19 ` Jeremy Fitzhardinge
2008-03-20 7:43 ` [patch 3/4] x86: vSMP: Use pvops only if platform has the capability to support it Ravikiran G Thirumalai
2008-03-20 7:45 ` [patch 4/4] x86: apic_is_clustered_box to indicate unsynched TSC's on multiboard vSMP systems Ravikiran G Thirumalai
2008-03-20 7:53 ` Yinghai Lu
2008-03-20 19:02 ` Ravikiran G Thirumalai
2008-03-21 9:15 ` Ingo Molnar
2008-03-21 18:52 ` Ravikiran G Thirumalai
2008-03-21 18:58 ` Ingo Molnar
2008-03-22 18:59 ` Ravikiran G Thirumalai
2008-03-22 20:02 ` Ingo Molnar
2008-03-24 21:48 ` Ravikiran G Thirumalai
2008-03-25 15:50 ` Ingo Molnar
2008-03-21 8:54 ` [patch 0/4] x86: vSMP updates Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440803200044g54617517k4530db76ebe2cabb@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=gcosta@redhat.com \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=shai@scalex86.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox