From: Thomas Gleixner <tglx@kernel.org>
To: Rosen Penev <rosenp@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip/dw-apb-ictl: fix compilation on x86
Date: Tue, 19 May 2026 19:16:46 +0200 [thread overview]
Message-ID: <8733znxqtd.ffs@tglx> (raw)
In-Reply-To: <20260519025703.817197-1-rosenp@gmail.com>
On Mon, May 18 2026 at 19:57, Rosen Penev wrote:
> __irq_entry belongs nowhere in irqchip drivers as it is an
> architecture specific annotation. There's no specific architecture
> depends for DW_APB_ICTL and there probably shouldn't be.
Care to see how that driver is selected? Certainly not by x86.
> Fixes:
>
> drivers/irqchip/irq-dw-apb-ictl.c:33:13: error: variable has incomplete type 'void'
> 33 | static void __irq_entry dw_apb_ictl_handle_irq(struct pt_regs *regs)
That's fixing nothing because the driver cannot be built on x86 and the
architectures which select it have a reason to move the handler into the
irqentry.text section via __irq_entry.
I'm slowly getting fed up by the AI slob which ends up in my inbox every
other day.
Thanks,
tglx
next prev parent reply other threads:[~2026-05-19 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 2:57 [PATCH] irqchip/dw-apb-ictl: fix compilation on x86 Rosen Penev
2026-05-19 17:16 ` Thomas Gleixner [this message]
2026-05-19 21:22 ` Rosen Penev
2026-05-20 9:01 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8733znxqtd.ffs@tglx \
--to=tglx@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox