From: Thomas Gleixner <tglx@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip/dw-apb-ictl: fix compilation on x86
Date: Wed, 20 May 2026 11:01:47 +0200 [thread overview]
Message-ID: <87zf1uwj2c.ffs@tglx> (raw)
In-Reply-To: <CAKxU2N_5WvgjpcUjaVArxZ_eZxPi-FhYzn=UzK-1tVLbukXYqg@mail.gmail.com>
On Tue, May 19 2026 at 14:22, Rosen Penev wrote:
> On Tue, May 19, 2026 at 10:16 AM Thomas Gleixner <tglx@kernel.org> wrote:
>>
>> On Mon, May 18 2026 at 19:57, Rosen Penev wrote:
>> > __irq_entry belongs nowhere in irqchip drivers as it is an
>> > architecture specific annotation. There's no specific architecture
>> > depends for DW_APB_ICTL and there probably shouldn't be.
>>
>> Care to see how that driver is selected? Certainly not by x86.
> make LLVM=1 ARCH=i386 allmodconfig
> make LLVM=1 ARCH=i386 -j 31
How does that select the config symbol?
Makefile:
obj-$(CONFIG_DW_APB_ICTL) += irq-dw-apb-ictl.o
Kconfig:
config DW_APB_ICTL
bool
select GENERIC_IRQ_CHIP
select IRQ_DOMAIN_HIERARCHY
# git grep DW_APB_ICTL
arch/arc/plat-axs10x/Kconfig: select DW_APB_ICTL
arch/arm/mach-berlin/Kconfig: select DW_APB_ICTL
arch/arm/mach-hisi/Kconfig: select DW_APB_ICTL
arch/arm64/Kconfig.platforms: select DW_APB_ICTL
arch/csky/Kconfig.platforms: select DW_APB_ICTL
i386 definitely does not select it.
# grep DW_APB_ICTL ../build-386/.config
#
prev parent reply other threads:[~2026-05-20 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 2:57 [PATCH] irqchip/dw-apb-ictl: fix compilation on x86 Rosen Penev
2026-05-19 17:16 ` Thomas Gleixner
2026-05-19 21:22 ` Rosen Penev
2026-05-20 9:01 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zf1uwj2c.ffs@tglx \
--to=tglx@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox