From: Thomas Gleixner <tglx@linutronix.de>
To: Gabriele Monaco <gmonaco@redhat.com>,
linux-kernel@vger.kernel.org,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
Waiman Long <longman@redhat.com>
Cc: Gabriele Monaco <gmonaco@redhat.com>
Subject: Re: [PATCH v6 1/6] timers: Rename tmigr 'online' bit to 'available'
Date: Fri, 20 Jun 2025 19:04:16 +0200 [thread overview]
Message-ID: <8734buqr8v.ffs@tglx> (raw)
In-Reply-To: <20250530142031.215594-2-gmonaco@redhat.com>
On Fri, May 30 2025 at 16:20, Gabriele Monaco wrote:
>
> -static int tmigr_cpu_offline(unsigned int cpu)
> +static int tmigr_cpu_unavailable(unsigned int cpu)
tmigr_clear_cpu_available() and tmigr_set_cpu_available() are way more
clear function names because they explicitly state the action.
cpu_offline/online are not entirely clear either but at least
offline/online can be used as verbs, while [un]available definitely
cannot.
Thanks,
tglx
next prev parent reply other threads:[~2025-06-20 17:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 14:20 [PATCH v6 0/6] timers: Exclude isolated cpus from timer migation Gabriele Monaco
2025-05-30 14:20 ` [PATCH v6 1/6] timers: Rename tmigr 'online' bit to 'available' Gabriele Monaco
2025-06-20 17:04 ` Thomas Gleixner [this message]
2025-05-30 14:20 ` [PATCH v6 2/6] timers: Add the available mask in timer migration Gabriele Monaco
2025-05-30 14:20 ` [PATCH v6 3/6] cgroup/cpuset: Rename update_unbound_workqueue_cpumask() to update_exclusion_cpumasks() Gabriele Monaco
2025-05-30 14:20 ` [PATCH v6 4/6] sched/isolation: Force housekeeping if isolcpus and nohz_full don't leave any Gabriele Monaco
2025-05-30 14:20 ` [PATCH v6 5/6] cgroup/cpuset: Fail if isolated and nohz_full don't leave any housekeeping Gabriele Monaco
2025-05-30 14:20 ` [PATCH v6 6/6] timers: Exclude isolated cpus from timer migation Gabriele Monaco
2025-06-20 17:00 ` Thomas Gleixner
2025-06-24 8:05 ` Gabriele Monaco
2025-06-24 13:20 ` Thomas Gleixner
2025-06-24 14:06 ` Gabriele Monaco
2025-06-24 14:52 ` Frederic Weisbecker
2025-06-25 10:45 ` Thomas Gleixner
2025-06-25 13:16 ` Frederic Weisbecker
2025-06-25 13:46 ` Gabriele Monaco
2025-06-25 14:42 ` Frederic Weisbecker
2025-06-18 12:17 ` [PATCH v6 0/6] " Gabriele Monaco
2025-06-18 12:22 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734buqr8v.ffs@tglx \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox