* [PATCH] ARM: mvebu: add missing of_node_put()
@ 2016-02-08 6:17 Masahiro Yamada
2016-02-08 16:31 ` Gregory CLEMENT
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2016-02-08 6:17 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Andrew Lunn, Sebastian Hesselbarth, Gregory Clement, Jason Cooper,
Masahiro Yamada, linux-kernel, Russell King
This node pointer is returned by of_find_compatible_node() in this
function. It should be put before exitting this function.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/mach-mvebu/platsmp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-mvebu/platsmp.c b/arch/arm/mach-mvebu/platsmp.c
index f9597b7..46c742d 100644
--- a/arch/arm/mach-mvebu/platsmp.c
+++ b/arch/arm/mach-mvebu/platsmp.c
@@ -140,6 +140,7 @@ static void __init armada_xp_smp_prepare_cpus(unsigned int max_cpus)
panic("Cannot find 'marvell,bootrom' compatible node");
err = of_address_to_resource(node, 0, &res);
+ of_node_put(node);
if (err < 0)
panic("Cannot get 'bootrom' node address");
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: mvebu: add missing of_node_put()
2016-02-08 6:17 [PATCH] ARM: mvebu: add missing of_node_put() Masahiro Yamada
@ 2016-02-08 16:31 ` Gregory CLEMENT
0 siblings, 0 replies; 2+ messages in thread
From: Gregory CLEMENT @ 2016-02-08 16:31 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-arm-kernel, Andrew Lunn, Sebastian Hesselbarth,
Jason Cooper, linux-kernel, Russell King
Hi Masahiro,
On lun., févr. 08 2016, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> This node pointer is returned by of_find_compatible_node() in this
> function. It should be put before exitting this function.
>
Applied on mvebu/cleanup
Thanks,
Gregory
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/arm/mach-mvebu/platsmp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-mvebu/platsmp.c b/arch/arm/mach-mvebu/platsmp.c
> index f9597b7..46c742d 100644
> --- a/arch/arm/mach-mvebu/platsmp.c
> +++ b/arch/arm/mach-mvebu/platsmp.c
> @@ -140,6 +140,7 @@ static void __init armada_xp_smp_prepare_cpus(unsigned int max_cpus)
> panic("Cannot find 'marvell,bootrom' compatible node");
>
> err = of_address_to_resource(node, 0, &res);
> + of_node_put(node);
> if (err < 0)
> panic("Cannot get 'bootrom' node address");
>
> --
> 1.9.1
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-08 16:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-08 6:17 [PATCH] ARM: mvebu: add missing of_node_put() Masahiro Yamada
2016-02-08 16:31 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox