* [PATCH] h8300: remove unnecessary of_platform_populate call
@ 2018-06-19 21:40 Rob Herring
2018-07-09 15:50 ` Rob Herring
2018-07-22 14:11 ` Yoshinori Sato
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2018-06-19 21:40 UTC (permalink / raw)
To: Yoshinori Sato; +Cc: linux-kernel, uclinux-h8-devel
The DT core will call of_platform_populate, so it is not necessary for
arch specific code to call it unless there are custom match entries,
auxdata or parent device. Neither of those apply here, so remove the call.
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: uclinux-h8-devel@lists.sourceforge.jp
Signed-off-by: Rob Herring <robh@kernel.org>
---
arch/h8300/kernel/setup.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c
index a4d0470c10a9..b2b51f75774e 100644
--- a/arch/h8300/kernel/setup.c
+++ b/arch/h8300/kernel/setup.c
@@ -23,7 +23,6 @@
#include <linux/init.h>
#include <linux/of.h>
#include <linux/of_fdt.h>
-#include <linux/of_platform.h>
#include <linux/of_address.h>
#include <linux/clk-provider.h>
#include <linux/memblock.h>
@@ -188,15 +187,6 @@ const struct seq_operations cpuinfo_op = {
.show = show_cpuinfo,
};
-static int __init device_probe(void)
-{
- of_platform_populate(NULL, NULL, NULL, NULL);
-
- return 0;
-}
-
-device_initcall(device_probe);
-
#if defined(CONFIG_CPU_H8300H)
#define get_wait(base, addr) ({ \
int baddr; \
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] h8300: remove unnecessary of_platform_populate call
2018-06-19 21:40 [PATCH] h8300: remove unnecessary of_platform_populate call Rob Herring
@ 2018-07-09 15:50 ` Rob Herring
2018-07-22 14:11 ` Yoshinori Sato
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2018-07-09 15:50 UTC (permalink / raw)
To: Yoshinori Sato
Cc: linux-kernel@vger.kernel.org, moderated list:H8/300 ARCHITECTURE
On Tue, Jun 19, 2018 at 3:40 PM Rob Herring <robh@kernel.org> wrote:
>
> The DT core will call of_platform_populate, so it is not necessary for
> arch specific code to call it unless there are custom match entries,
> auxdata or parent device. Neither of those apply here, so remove the call.
>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: uclinux-h8-devel@lists.sourceforge.jp
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/h8300/kernel/setup.c | 10 ----------
> 1 file changed, 10 deletions(-)
Ping?
>
> diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c
> index a4d0470c10a9..b2b51f75774e 100644
> --- a/arch/h8300/kernel/setup.c
> +++ b/arch/h8300/kernel/setup.c
> @@ -23,7 +23,6 @@
> #include <linux/init.h>
> #include <linux/of.h>
> #include <linux/of_fdt.h>
> -#include <linux/of_platform.h>
> #include <linux/of_address.h>
> #include <linux/clk-provider.h>
> #include <linux/memblock.h>
> @@ -188,15 +187,6 @@ const struct seq_operations cpuinfo_op = {
> .show = show_cpuinfo,
> };
>
> -static int __init device_probe(void)
> -{
> - of_platform_populate(NULL, NULL, NULL, NULL);
> -
> - return 0;
> -}
> -
> -device_initcall(device_probe);
> -
> #if defined(CONFIG_CPU_H8300H)
> #define get_wait(base, addr) ({ \
> int baddr; \
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] h8300: remove unnecessary of_platform_populate call
2018-06-19 21:40 [PATCH] h8300: remove unnecessary of_platform_populate call Rob Herring
2018-07-09 15:50 ` Rob Herring
@ 2018-07-22 14:11 ` Yoshinori Sato
1 sibling, 0 replies; 3+ messages in thread
From: Yoshinori Sato @ 2018-07-22 14:11 UTC (permalink / raw)
To: Rob Herring; +Cc: linux-kernel, uclinux-h8-devel
On Wed, 20 Jun 2018 06:40:54 +0900,
Rob Herring wrote:
>
> The DT core will call of_platform_populate, so it is not necessary for
> arch specific code to call it unless there are custom match entries,
> auxdata or parent device. Neither of those apply here, so remove the call.
>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: uclinux-h8-devel@lists.sourceforge.jp
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/h8300/kernel/setup.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c
> index a4d0470c10a9..b2b51f75774e 100644
> --- a/arch/h8300/kernel/setup.c
> +++ b/arch/h8300/kernel/setup.c
> @@ -23,7 +23,6 @@
> #include <linux/init.h>
> #include <linux/of.h>
> #include <linux/of_fdt.h>
> -#include <linux/of_platform.h>
> #include <linux/of_address.h>
> #include <linux/clk-provider.h>
> #include <linux/memblock.h>
> @@ -188,15 +187,6 @@ const struct seq_operations cpuinfo_op = {
> .show = show_cpuinfo,
> };
>
> -static int __init device_probe(void)
> -{
> - of_platform_populate(NULL, NULL, NULL, NULL);
> -
> - return 0;
> -}
> -
> -device_initcall(device_probe);
> -
> #if defined(CONFIG_CPU_H8300H)
> #define get_wait(base, addr) ({ \
> int baddr; \
> --
> 2.17.1
>
Sorry. too late reply.
Applied to h8300-next.
Thanks.
--
Yosinori Sato
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-22 14:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-19 21:40 [PATCH] h8300: remove unnecessary of_platform_populate call Rob Herring
2018-07-09 15:50 ` Rob Herring
2018-07-22 14:11 ` Yoshinori Sato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox