From: Jonathan Corbet <corbet@lwn.net>
To: Nir Lichtman <nir@lichtman.org>,
jason.wessel@windriver.com, daniel.thompson@linaro.org,
dianders@chromium.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Documentation: English fixes in kgdb/kdb article
Date: Fri, 18 Oct 2024 17:10:38 -0600 [thread overview]
Message-ID: <87wmi5vwgh.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20241018223536.GA799515@lichtman.org>
A couple of comments..
Nir Lichtman <nir@lichtman.org> writes:
> Minor grammar and typos fixed in the kgdb/kdb article
>
> Signed-off-by: Nir Lichtman <nir@lichtman.org>
> ---
When you post followup versions to a patch, please put an explanation in
this space saying what has changed; that makes life easier for
reviewers.
> Documentation/dev-tools/kgdb.rst | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
Beyond that, it is good to wait a little while before posting new
versions to let other reviews come through. Three iterations in one day
are a bit much.
That said, the patch looks OK now; I'll apply it shortly.
Thanks,
jon
next prev parent reply other threads:[~2024-10-18 23:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 16:31 [PATCH] Documentation: English fixes in kgdb/kdb article Nir Lichtman
2024-10-18 17:27 ` Matthew Wilcox
2024-10-18 17:49 ` Nir Lichtman
2024-10-18 17:56 ` Matthew Wilcox
2024-10-18 17:55 ` [PATCH v2] " Nir Lichtman
2024-10-18 19:46 ` Doug Anderson
2024-10-18 22:21 ` Nir Lichtman
2024-10-18 22:35 ` [PATCH v3] " Nir Lichtman
2024-10-18 22:49 ` Doug Anderson
2024-10-18 23:10 ` Jonathan Corbet [this message]
2024-10-19 5:50 ` Nir Lichtman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmi5vwgh.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nir@lichtman.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox