* [PATCH v1] ALSA: hda/tas2781: Add bus name in device name check
@ 2025-07-05 2:53 Baojun Xu
2025-07-06 8:22 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Baojun Xu @ 2025-07-05 2:53 UTC (permalink / raw)
To: tiwai
Cc: broonie, andriy.shevchenko, alsa-devel, shenghao-ding, navada,
13916275206, v-hampiholi, v-po, linux-sound, linux-kernel,
baojun.xu
Device name start from bus name, as we use strstarts()
to do compare, need add it for TXNW2781 device.
Fixes: b2904df0a347 ("ALSA: hda/tas2781: Add compatible for hardware id TIAS2781 and TXNW2781")
Signed-off-by: Baojun Xu <baojun.xu@ti.com>
---
sound/pci/hda/tas2781_hda_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
index b9cdbca951e4..530c2266ab3b 100644
--- a/sound/pci/hda/tas2781_hda_i2c.c
+++ b/sound/pci/hda/tas2781_hda_i2c.c
@@ -588,7 +588,7 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt)
hda_priv->save_calibration = tas2781_save_calibration;
tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR;
} else if (strstarts(dev_name(&clt->dev),
- "TXNW2781:00-tas2781-hda.0")) {
+ "i2c-TXNW2781:00-tas2781-hda.0")) {
device_name = "TXNW2781";
hda_priv->save_calibration = tas2781_save_calibration;
tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR;
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1] ALSA: hda/tas2781: Add bus name in device name check
2025-07-05 2:53 [PATCH v1] ALSA: hda/tas2781: Add bus name in device name check Baojun Xu
@ 2025-07-06 8:22 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2025-07-06 8:22 UTC (permalink / raw)
To: Baojun Xu
Cc: broonie, andriy.shevchenko, alsa-devel, shenghao-ding, navada,
13916275206, v-hampiholi, v-po, linux-sound, linux-kernel
On Sat, 05 Jul 2025 04:53:33 +0200,
Baojun Xu wrote:
>
> Device name start from bus name, as we use strstarts()
> to do compare, need add it for TXNW2781 device.
>
> Fixes: b2904df0a347 ("ALSA: hda/tas2781: Add compatible for hardware id TIAS2781 and TXNW2781")
>
> Signed-off-by: Baojun Xu <baojun.xu@ti.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1] ALSA: hda/tas2781: Add bus name in device name check
@ 2025-07-03 0:06 Baojun Xu
2025-07-03 9:41 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Baojun Xu @ 2025-07-03 0:06 UTC (permalink / raw)
To: tiwai
Cc: broonie, andriy.shevchenko, alsa-devel, shenghao-ding, navada,
13916275206, v-hampiholi, v-po, linux-sound, linux-kernel,
baojun.xu
Device name start from bus name, as we use strstarts()
to do compare, need add it for TXNW2781 device.
Signed-off-by: Baojun Xu <baojun.xu@ti.com>
---
sound/pci/hda/tas2781_hda_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
index b9cdbca95..530c2266a 100644
--- a/sound/pci/hda/tas2781_hda_i2c.c
+++ b/sound/pci/hda/tas2781_hda_i2c.c
@@ -588,7 +588,7 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt)
hda_priv->save_calibration = tas2781_save_calibration;
tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR;
} else if (strstarts(dev_name(&clt->dev),
- "TXNW2781:00-tas2781-hda.0")) {
+ "i2c-TXNW2781:00-tas2781-hda.0")) {
device_name = "TXNW2781";
hda_priv->save_calibration = tas2781_save_calibration;
tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR;
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1] ALSA: hda/tas2781: Add bus name in device name check
2025-07-03 0:06 Baojun Xu
@ 2025-07-03 9:41 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2025-07-03 9:41 UTC (permalink / raw)
To: Baojun Xu
Cc: broonie, andriy.shevchenko, alsa-devel, shenghao-ding, navada,
13916275206, v-hampiholi, v-po, linux-sound, linux-kernel
On Thu, 03 Jul 2025 02:06:08 +0200,
Baojun Xu wrote:
>
> Device name start from bus name, as we use strstarts()
> to do compare, need add it for TXNW2781 device.
>
> Signed-off-by: Baojun Xu <baojun.xu@ti.com>
Could you give the proper Fixes tag if it's a fix of the previous
changes?
thanks,
Takashi
> ---
> sound/pci/hda/tas2781_hda_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
> index b9cdbca95..530c2266a 100644
> --- a/sound/pci/hda/tas2781_hda_i2c.c
> +++ b/sound/pci/hda/tas2781_hda_i2c.c
> @@ -588,7 +588,7 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt)
> hda_priv->save_calibration = tas2781_save_calibration;
> tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR;
> } else if (strstarts(dev_name(&clt->dev),
> - "TXNW2781:00-tas2781-hda.0")) {
> + "i2c-TXNW2781:00-tas2781-hda.0")) {
> device_name = "TXNW2781";
> hda_priv->save_calibration = tas2781_save_calibration;
> tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR;
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-06 8:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-05 2:53 [PATCH v1] ALSA: hda/tas2781: Add bus name in device name check Baojun Xu
2025-07-06 8:22 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2025-07-03 0:06 Baojun Xu
2025-07-03 9:41 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox